Edgewall Software
Modify ↓

Opened 6 years ago

Closed 6 years ago

#13060 closed defect (fixed)

TicketSystem.custom_fields includes invalid field names

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.18
Component: ticket system Version:
Severity: normal Keywords: custom fields
Cc: Branch:
Release Notes:
API Changes:

Fixed invalid custom fields returned by TicketSystem.custom_fields and TicketSystem.get_custom_fields.

Internal Changes:

Description

TicketSystem.custom_fields, and by extension TicketSystem.get_custom_fields, include invalid custom fields. However, those invalid fields are not returned by TicketSystem.fields (and TicketSystem.get_ticket_fields).

The filtering that removes invalid custom fields is in TicketSystem.fields​. The filtering should be moved to TicketSystem.custom_fields​.

Attachments (0)

Change History (3)

comment:2 by Jun Omae, 6 years ago

Looks good to me.

BTW, log:rjollos.git:t13060_custom_field_validation+1.2-stable and log:rjollos.git:t13060_custom_field_validation+trunk branches refer the same commit for trunk.

comment:3 by Ryan J Ollos, 6 years ago

Resolution: → fixed
Status: assigned → closed

Thanks for review, committed to 1.0-stable in r16762, merged in r16763 and r16764.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.