TypeError: 'annotateline' object is not iterable

[anonymous]

After upgrading Mercurial, Trac blame doesn't work anymore:

2018-06-19 10:29:04,944 Trac[api] WARNING: HTML preview using PygmentsRenderer with <RenderingContext <Resource u'repository:R1, source:R1/a.c@deba02c781bc32a84b7f1d63e216912306ae71fd8a6'>> failed: 
Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\mimeview\api.py", line 811, in render
    return self._render_source(context, result, annotations)
  File "build\bdist.win32\egg\trac\mimeview\api.py", line 848, in _render_source
    data = (annotator, annotator.get_annotation_data(context))
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 875, in get_annotation_data
    return BlameAnnotator(self.env, context)
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 981, in __init__
    self.reset()
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 988, in reset
    self.annotations = node.get_annotations()
  File "build\bdist.win32\egg\tracext\hg\backend.py", line 1225, in get_annotations
    for fc, line in self.filectx.annotate(follow=True):
TypeError: 'annotateline' object is not iterable
2018-06-19 10:29:05,010 Trac[api] WARNING: HTML preview using PlainTextRenderer with <RenderingContext <Resource u'repository:R1, source:R1/a.c@a02c781bc32a84b7f1d63e216912306ae71fd8a6'>> failed: 
Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\mimeview\api.py", line 811, in render
    return self._render_source(context, result, annotations)
  File "build\bdist.win32\egg\trac\mimeview\api.py", line 848, in _render_source
    data = (annotator, annotator.get_annotation_data(context))
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 875, in get_annotation_data
    return BlameAnnotator(self.env, context)
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 981, in __init__
    self.reset()
  File "build\bdist.win32\egg\trac\versioncontrol\web_ui\browser.py", line 988, in reset
    self.annotations = node.get_annotations()
  File "build\bdist.win32\egg\tracext\hg\backend.py", line 1225, in get_annotations
    for fc, line in self.filectx.annotate(follow=True):
TypeError: 'annotateline' object is not iterable

• Trac 1.3.2dev
• Mercurial 4.6
• tracmercurial 1.0.0.7 source:mercurial-plugin@51 (d9139f9a3601)

[anonymous]

Guessing from ​https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/context.py#l888 I tried this change:

tracext/hg/backend.py

@@ -1222 +1222 @@
     def get_annotations(self):
         annotations = []
         if self.filectx:
-            for fc, line in self.filectx.annotate(follow=True):
-                if isinstance(fc, tuple):
-                    fc = fc[0]
+            for annotateline in self.filectx.annotate(follow=True):
+                if isinstance(annotateline, tuple):
+                    fc = annotateline[0]
+                    if isinstance(fc, tuple):
+                        fc = fc[0]
+                else:
+                    fc = annotateline.fctx
                 annotations.append(fc.rev() or '0')
         return annotations

And it seems to work.

[Jun Omae]

A duplicate of #13036.

[Jun Omae]

Guessing from ​https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/context.py#l888 I tried this change: […]

The patch seems to be good with all versions of mercurial (3.8, 3.9, 4.6). Thanks.

[anonymous]

(I only searched search:annotateline+iterable and missed the other ticket.)

[anonymous]

BTW is there a reason TracMercurial#Releases does not mention version 1.0.0.5 to 1.0.0.8, compatibility with Trac 1.2+ / hg 3.2+?

[Ryan J Ollos]

Replying to anonymous:

BTW is there a reason TracMercurial#Releases does not mention version 1.0.0.5 to 1.0.0.8, compatibility with Trac 1.2+ / hg 3.2+?

I suspect the page hasn't been updated with recent releases. Please feel free to update it.

[anonymous]

Updated in wiki:TracMercurial?action=diff&version=114