Edgewall Software
Modify ↓

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#13034 closed defect (fixed)

Babel 2.6.0 drops support of Python 2.6

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.17
Component: general Version:
Severity: normal Keywords: babel
Cc: Branch:
Release Notes:

Pin Babel version in Travis CI with Python 2.6.

API Changes:
Internal Changes:

Description

​Babel 2.6.0 is released and drops support for EOL Python 2.6 and 3.3 by ​pr#546.

We should pin Babel versions in Travis CI and ​Appveyor for 1.0-stable and 1.2-stable:

  • .travis.yml 

    diff --git a/.travis.yml b/.travis.yml
index 5cd7e66ac..baf7668fb 100644
    a b install:  
    9898      python -c 'from svn import core'
    9999    fi
    100100  - |
    101     requires='Genshi==0.7 Babel!=2.3.0,!=2.3.1 configobj Pygments docutils textile lxml pytz twill==0.9.1 setuptools_git'
     101    requires='Genshi==0.7 Babel<2.6.0 configobj Pygments docutils textile lxml pytz twill==0.9.1 setuptools_git'
    102102    if [ "$tracdb" = postgres ]; then requires="$requires psycopg2"; fi
    103103    if [ "$tracdb" = mysql ]; then requires="$requires MySQL-python"; fi
    104104    pip install $requires

  • contrib/appveyor.ps1 

    diff --git a/contrib/appveyor.ps1 b/contrib/appveyor.ps1
index b9b5029c2..5aea36008 100644
    a b $pgPassword = 'Password12!'  
    5454
    5555$pipCommonPackages = @(
    5656    'genshi',
    57     'babel!=2.3.0,!=2.3.1',
     57    'babel<2.6.0',
    5858    'twill==0.9.1',
    5959    'configobj',
    6060    'docutils',

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 6 years ago

Looks like a good idea.

comment:2 by Jun Omae, 6 years ago

Reconsidering:

  • Babel version should be pinned only with Python 2.6.
  • The pin in Appveyor is not needed since Python 2.6 is no longer available.

  • .travis.yml 

    commit 94730e76c5684ca8637a96147bd45aca479e1308
Author: Jun Omae <jun66j5@gmail.com>
Date:   Mon Jun 4 04:08:12 2018 +0900

    (#13034) pin Babel version in Travis CI for Python 2.6

diff --git a/.travis.yml b/.travis.yml
index 5cd7e66ac..7dcfef323 100644
    a b install:  
    9898      python -c 'from svn import core'
    9999    fi
    100100  - |
    101     requires='Genshi==0.7 Babel!=2.3.0,!=2.3.1 configobj Pygments docutils textile lxml pytz twill==0.9.1 setuptools_git'
     101    requires='Genshi==0.7 configobj Pygments docutils textile lxml pytz twill==0.9.1 setuptools_git'
     102    case "$pyver" in
     103      2.6) requires="$requires Babel<2.6.0" ;;
     104      *)   requires="$requires Babel" ;;
     105    esac
    102106    if [ "$tracdb" = postgres ]; then requires="$requires psycopg2"; fi
    103107    if [ "$tracdb" = mysql ]; then requires="$requires MySQL-python"; fi
    104108    pip install $requires

  • contrib/appveyor.ps1 

    diff --git a/contrib/appveyor.ps1 b/contrib/appveyor.ps1
index b9b5029c2..f18227eb5 100644
    a b $pgPassword = 'Password12!'  
    5454
    5555$pipCommonPackages = @(
    5656    'genshi',
    57     'babel!=2.3.0,!=2.3.1',
     57    'babel',
    5858    'twill==0.9.1',
    5959    'configobj',
    6060    'docutils',

in reply to:  2 comment:3 by Ryan J Ollos, 6 years ago

Replying to Jun Omae:

Reconsidering:

  • Babel version should be pinned only with Python 2.6.
  • The pin in Appveyor is not needed since Python 2.6 is no longer available.

Yeah, that looks good.

comment:4 by Jun Omae, 6 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: new → closed

Committed in [16661] and merged in [16662-16663].

comment:5 by Jun Omae, 6 years ago

Owner: set to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.