Opened 6 years ago
Last modified 4 years ago
#12968 closed defect
preview_file.html rev 16379 (via include in browser.html): "ParseError: mismatched tag" caused by dangling </p> — at Initial Version
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Milestone: | 1.3.3 |
Component: | version control/browser | Version: | 1.3dev |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
Lines 50 and 51 of preview_file.html of rev 16379 need to be swapped so that the final "</p>" on line 51 is enclosed in the final "# endif", otherwise the dangling </p> generated by preview_file.html will report the error "ParseError: mismatched tag: line ###, column #" when trying to view a file in the repo.
Please see preview_file.html rev 16379: https://trac.edgewall.org/browser/trunk/trac/templates/preview_file.html?rev=16379#L51
In the current trunk source code, this can be reproduced simply by clicking on any link to a file in the repo that results in use of the "browser.html" template that includes preview_file.html.
I've attached a patch that solves for this bug.
NOTE: I'd be happy to make such corrections directly if I were given access to make changes in the Trac trunk.
Thanks for all your help making Trac what it is today.
swap lines 50 and 51 of preview_file.html to correct "ParseError: mismatched tag" caused by dangling </p>