Edgewall Software

Opened 5 years ago

Closed 5 years ago

Last modified 2 years ago

#12968 closed defect (fixed)

preview_file.html rev 16379 (via include in browser.html): "ParseError: mismatched tag" caused by dangling </p>

Reported by: richard@… Owned by: richard@…
Priority: normal Milestone: 1.3.3
Component: version control/browser Version: 1.3dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Fix unbalanced </p> in preview_file.html.

Description (last modified by Jun Omae)

Lines 50 and 51 of preview_file.html of r16379 need to be swapped so that the final </p> on line 51 is enclosed in the final # endif, otherwise the dangling </p> generated by preview_file.html will report the error ParseError: mismatched tag: line ###, column # when trying to view a file in the repo.

Please see preview_file.html rev 16379: source:/trunk/trac/templates/preview_file.html@16379#L51

In the current trunk source code, this can be reproduced simply by clicking on any link to a file in the repo that results in use of the browser.html template that includes preview_file.html.

I've attached a patch that solves for this bug.

NOTE: I'd be happy to make such corrections directly if I were given access to make changes in the Trac trunk.

Thanks for all your help making Trac what it is today.

Attachments (1)

preview_file.html.patch (271 bytes ) - added by richard@… 5 years ago.
swap lines 50 and 51 of preview_file.html to correct "ParseError: mismatched tag" caused by dangling </p>

Download all attachments as: .zip

Change History (6)

by richard@…, 5 years ago

Attachment: preview_file.html.patch added

swap lines 50 and 51 of preview_file.html to correct "ParseError: mismatched tag" caused by dangling </p>

comment:1 by Jun Omae, 5 years ago

Description: modified (diff)

comment:2 by Jun Omae, 5 years ago

Thanks for the reporting. We will apply the patch but should add unit tests for the regression.

comment:3 by Jun Omae, 5 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Fixed in [16412].

comment:4 by Jun Omae, 5 years ago

Owner: set to richard@…

comment:5 by Ryan J Ollos, 2 years ago

Internal Changes: modified (diff)
Release Notes: modified (diff)

Moving to Internal Changes since the regression did not appear in a stable release (only developer-stable).

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain richard@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from richard@… to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.