preview_file.html rev 16379 (via include in browser.html): "ParseError: mismatched tag" caused by dangling </p>

[richard@…]

Lines 50 and 51 of preview_file.html of r16379 need to be swapped so that the final </p> on line 51 is enclosed in the final # endif, otherwise the dangling </p> generated by preview_file.html will report the error ParseError: mismatched tag: line ###, column # when trying to view a file in the repo.

Please see preview_file.html rev 16379: source:/trunk/trac/templates/preview_file.html@16379#L51​

In the current trunk source code, this can be reproduced simply by clicking on any link to a file in the repo that results in use of the browser.html template that includes preview_file.html.

I've attached a patch that solves for this bug.

NOTE: I'd be happy to make such corrections directly if I were given access to make changes in the Trac trunk.

Thanks for all your help making Trac what it is today.

[richard@…]

swap lines 50 and 51 of preview_file.html to correct "ParseError: mismatched tag" caused by dangling </p>

[Jun Omae]

Thanks for the reporting. We will apply the patch but should add unit tests for the regression.

[Jun Omae]

Fixed in [16412].

[Ryan J Ollos]

Moving to Internal Changes since the regression did not appear in a stable release (only developer-stable).