Query page raises a TypeError if custom field named "id" exists

[Jun Omae]

How to reproduce

1. Create new environment — initenv
2. Add a custom field named "id" — config set ticket-custom id text
3. Create new ticket
4. Visit /query?status=!closed

07:39:35 PM Trac[main] ERROR: [192.168.11.25] Internal Server Error: <RequestWithSession "GET '/query?status=!closed'">, referrer None
Traceback (most recent call last):
  File "/venv/trac/1.0.15/lib/python2.5/site-packages/trac/web/main.py", line 567, in _dispatch_request
    dispatcher.dispatch(req)
  File "/venv/trac/1.0.15/lib/python2.5/site-packages/trac/web/main.py", line 249, in dispatch
    resp = chosen_handler.process_request(req)
  File "/venv/trac/1.0.15/lib/python2.5/site-packages/trac/ticket/query.py", line 1004, in process_request
    return self.display_html(req, query)
  File "/venv/trac/1.0.15/lib/python2.5/site-packages/trac/ticket/query.py", line 1102, in display_html
    tickets = query.execute(req)
  File "/venv/trac/1.0.15/lib/python2.5/site-packages/trac/ticket/query.py", line 334, in execute
    val = int(val)
TypeError: int() argument must be a string or a number, not 'NoneType'

We should add id to reserved field names in TicketSystem:

trac/ticket/api.py

@@ -364 +364 @@
 
     reserved_field_names = ['report', 'order', 'desc', 'group', 'groupdesc',
                             'col', 'row', 'format', 'max', 'page', 'verbose',
-                            'comment', 'or']
+                            'comment', 'or', 'id']
 
     def get_custom_fields(self):
         return copy.deepcopy(self.custom_fields)

I'll post unit tests later.

[Jun Omae]

Proposed changes in [b4c1e5862/jomae.git].

[Ryan J Ollos]

Looks good to me.

[Jun Omae]

Thanks. Committed in [16403] and merged in [16404,16405].