Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12955 closed defect (duplicate)

batch-modify IGNORES plugin classes implementing the ITicketManipulator (validate_ticket before save), possibly ITicketChangeListener as well

Reported by: Stefan Gerstmayr <kyb.stefan@…> Owned by:
Priority: normal Milestone:
Component: ticket system Version: 1.2.2
Severity: normal Keywords: batch-modify, ITicketManipulator, ITicketChangeListener
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I use the ITicketManipulator extension point to implement a plugin that block specific changes to tickets by using the "validate_ticket" function before they get changed. This works well in the "Ticket View", but …

I just noticed, that on batch-modify my class implementing ITicketManipulator is ignored and all actions that the class should avoid can be easily performed on batch editing.

I suggest that the "batch-modify" has to ensure that the general extensions points of the ticket systems are correctly called ("validate_ticket" of all classes implementing ITicketManipulator needs to be called). This also counts for the ITicketChangeListener ("ticket_changed" and "ticket_deleted" need to be called as well)

Attachments (0)

Change History (2)

comment:1 by anonymous, 7 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #11723.

in reply to:  description comment:2 by Ryan J Ollos, 7 years ago

Replying to Stefan Gerstmayr <kyb.stefan@…>:

This also counts for the ITicketChangeListener ("ticket_changed" and "ticket_deleted" need to be called as well)

There was never a defect with ITicketChangeListener. The change listener methods are called by Ticket.save_changes: tags/trac-1.2.2/trac/ticket/batch.py@:209#L186.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.