Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12952 closed enhancement (wontfix)

Add support for mysqlclient library

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone:
Component: database backend Version:
Severity: normal Keywords: mysql
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Discussed in ​gdiscussion:trac-users:ET632_nYAc0. Tests pass with mysqlclient 1.3.12.

This would allow us to support MySQL 5.5+ and platforms that are no longer providing MySQLdb through the package manager. For Trac 1.3.2 and later PyMySQL is supported (#12821).

Attachments (0)

Change History (6)

comment:1 by Jun Omae, 3 years ago

Changing requirements to MySQL-python or mysqlclient is best but it is unable to do it due to invalid syntax.

-        'mysql': ['MySQL-python >= 1.2.2'],
+        'mysql': ['MySQL-python >= 1.2.2 or mysqlclient'],

Trac 1.2.x supports Python 2.6 but mysqlclient doesn't support Python 2.6. However, tests pass with mysqlclient 1.3.12 on Python 2.6.

comment:2 by Jun Omae, 3 years ago

I don't think it is good to change requirements for mysql in minor upgrade.

comment:3 by Ryan J Ollos, 3 years ago

Milestone: 1.2.3
Resolution: wontfix
Status: assignedclosed

comment:4 by anonymous, 3 years ago

It's a pitty that this patch is not going to be integrated, since this bug effects all debian-based distributions since Debian stretch (stable), e.g.

  • Debian stretch, buster, sid and probably all future releases since the current package maintainer does not have the time to upgrade the package to a new main version
  • Ubuntu zesty, artful, bionic and probably all future releases

Since these distributions use Python 2.7 dropping the support for Python 2.6 wouldn't be a problem in this case. Is it possible to apply a mini-patch to those installations which solves the incompatibility problem? (Some patch that is applied against an installation, not an setup.py)

If there is one, I will send it to the Debian package maintainer, so that he can patch the Debian packages.

comment:5 by stefan@…, 3 years ago

I just forgot to add my mail address to get updates of this issue.

comment:6 by Ryan J Ollos, 3 years ago

I'm not sure how dependency management works in Debian, but I suggest communicating with the Debian package maintainer and referring that person to the patch in this ticket.

I have no problem with the patch, but all maintainers must agree for it to be applied. I agree that requirements typically shouldn't be changed in a minor release, but practicality is more important than strict rules.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.