TracError is not raised even if <action>.set_resolution is empty

[Jun Omae]

At tags/trac-1.0.15/trac/ticket/default_workflow.py@:280-281,284#L278​, it seems TracError with the following message is raised if resolutions specified in set_resolution attribute are not available.

Your workflow attempts to set a resolution but none is defined
 (configuration issue, please contact your Trac admin).

However, the exception is not actually raised because the following expression would be [''], not an empty list.

                resolutions = [x.strip() for x in
                               this_action['set_resolution'].split(',')]

>>> this_action = {'set_resolution': ''}
>>> [x.strip() for x in this_action['set_resolution'].split(',')]
['']

Another issue, I think we should ignore undefined resolutions specified in the set_resolution attribute. Currently, any values can be specified in.

[Jun Omae]

Proposed changes in [4fc9ed549/jomae.git] (jomae.git@t12882).

[Ryan J Ollos]

Checking for valid resolutions is a good idea. I documented the constraint in TracWorkflow@74.

Two notes:

• r13443 and r13445 used to_list so the none is defined error is correctly raised on 1.2-stable and trunk
• We might want to raise ConfigurationError

[Jun Omae]

Thanks. That makes sense.

Revised branch and created branches for 1.2-stable and trunk:

• jomae.git@t12882 for 1.0-stable
• jomae.git@t12882+1.2
• jomae.git@t12882+trunk

[Ryan J Ollos]

Looks good to me.

[Jun Omae]

Committed in [16253] and merged in [16254-16255].

[Ryan J Ollos]

Milestone renamed