Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12879 closed enhancement (fixed)

Use consistent styling for reporter and owner property changes

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.3
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Values in owner, reporter and CC property changes are decorated with trac-author-* classes (by Chrome.authorinfo).

Internal Changes:

Description (last modified by Ryan J Ollos)

This could be done by using chrome.authorinfo rather than chrome.format_author.

Attachments (2)

Screen Shot 2017-08-03 at 18.41.01.png​ (58.4 KB ) - added by Ryan J Ollos 7 years ago.
Screen Shot 2017-08-24 at 22.29.02.png​ (41.3 KB ) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (9)

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-08-03 at 18.41.01.png​ added

comment:1 by Ryan J Ollos, 7 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 7 years ago

Proposed changes in [7cbafab0d/rjollos.git].

comment:3 by Ryan J Ollos, 7 years ago

Milestone: → 1.3.3

I'll revise these changes. I found a few more issues I'd like to fix.

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-08-24 at 22.29.02.png​ added

comment:4 by Ryan J Ollos, 7 years ago

Some fields are duplicated when viewing the description diff (/ticket/1?action=diff). In the example below, Reporter is duplicated.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

Current behavior is:

  • The fields reporter, owner and cc, and list types are rendered with emphasis on the old and new values.
  • For most other fields the values are wrapped in a span with a class: trac-field-old, trac-field-new, trac-field-deleted. The styling of 'new' is bold, 'deleted' is strike-through.

I think there is more to be done to make the property change rendering more consistent for the various fields and types. For now, I'd like to propose:

  • Refactoring that moves all the rendering to _render_property_diff. Previously this was split across the ticket_change.html, _render_property_changes and _render_property_diff.
  • Removing the emphasis and using authorinfo as the element renderer for reporter, owner and CC entries.

Proposed changes in log:rjollos.git:t12879_author_in_ticket_change_properties.1.

comment:6 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Committed to trunk in r16282.

comment:7 by Ryan J Ollos, 5 years ago

API Changes: modified (diff)
Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.