Attachments (0)
Change History (4)
follow-up: 3 comment:1 by , 7 years ago
comment:2 by , 7 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
Revised proposed changes in [2753b29a5/jomae.git] (jomae.git@t12867).
query.js has the same issue. Proposed changes would fix this issue in both query.html and query.js.
comment:3 by , 7 years ago
Replying to Jun Omae:
<label>${_("between")}</label>
and<label>${_("and")}</label>
,<label>
element with no control and nofor
attribute does nothing.
Good find. I've tested and proposed changes look good to me.
comment:4 by , 7 years ago
Milestone: | 1.3.3 → 1.3.2 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Thanks for the testing! Committed with additional changes in [16146].
The additional changes is to use jQuery.parseHTML(_("..."))
to parse html explicitly rather than jQuery(_("..."))
. The localized string might not be started with <label>
.
According to http://api.jquery.com/jQuery/#creating-new-elements:
If a string is passed as the parameter to $(), jQuery examines the string to see if it looks like HTML (i.e., it starts with <tag … >). If not, the string is interpreted as a selector expression, as explained above.
<label>${_("between")}</label>
and<label>${_("and")}</label>
,<label>
element with no control and nofor
attribute does nothing.I think extracted messages would be simple and clear to modify to be the message with
<label>
elements:trac/ticket/templates/query.html