Edgewall Software
Modify ↓

Opened 8 years ago

Closed 8 years ago

#12855 closed defect (fixed)

No workflow hint for accept action when owner == self

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.3
Component: ticket system Version: 1.2.2
Severity: normal Keywords: workflow
Cc: Branch:
Release Notes:

Workflow action is not shown for set_owner_to_self operation when ticket status is equal to the new state and ticket owner is the logged-in user.

API Changes:
Internal Changes:

Description

The issue can be seen on trac-hacks.org, which has: 

accept = new,accepted,assigned,reopened -> accepted
accept.operations = set_owner_to_self
accept.permissions = TICKET_MODIFY

Rather than adding a workflow hint, I think we should just not render the accept (or assign) action when owner == self.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 8 years ago

Release Notes: modified (diff)

Proposed changes in log:rjollos.git:t12855_accept_action.

comment:2 by Jun Omae, 8 years ago

I consider we should change ConfigurableTicketWorkflow.get_ticket_actions() to filter an action which has only set_owner_to_self operator for ticket which is ticket['owner'] == req.authname, rather than changing render_ticket_action_control().

comment:3 by Ryan J Ollos, 8 years ago

Good idea. Revised changes: log:rjollos.git:t12855_accept_action.1.

comment:4 by Ryan J Ollos, 8 years ago

Resolution: → fixed
Status: assigned → closed

Committed to 1.2-stable in [16098:16099]. Merged to trunk in [16100:16101].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.