Modify ↓
Opened 7 years ago
Closed 7 years ago
#12813 closed enhancement (wontfix)
Get resource from request
| Reported by: | Ryan J Ollos | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | resource |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
VotePlugin needs to get the resource for a request. It currently does this in a way that isn't entirely robust, see resource_from_path. See also th:#11073.
The reason the method isn't robust is that it assume the path / corresponds to wiki/WikiStart, but this depends on [trac] default_handler and the session preference for default handler.
I seem to remember the issue coming up for other plugins (BookmarkPlugin?) as well, and it may be needed for #11078.
I've considered adding a function resource_from_request. The resource realm, id, parent realm/id and version can be parsed from the URL. However, I'm unsure how to get the resource for a request to /. Any ideas?
Attachments (0)
Change History (6)
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | next-dev-1.3.x → next-major-releases |
comment:3 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:4 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:5 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:6 by , 7 years ago
| Milestone: | next-major-releases |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
A solution was implemented for VotePlugin so that
resource_from_pathis no longer needed. See comment:7:ticket:11073.