Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12811 closed enhancement (fixed)

BatchModify support for table footer

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.2
Component: ticket system Version:
Severity: normal Keywords: batch-modify
Cc: Branch:
Release Notes:
API Changes:

Query result headings have the class trac-query-heading, result bodies have the class trac-query-results. Summary rows added by plugins should have the class trac-query-summary.

Internal Changes:

Description

SumFields adds a row at the end of each query results table. Reported in th:#13180, the row has a checkbox added to it, which when selected results in an exception for a batch modify request.

I'm changing SumFields to instead add the row in a tfoot. With some minor changes to batch modify a select box won't be added to a tfoot row.

Attachments (1)

Screen Shot 2017-05-17 at 12.01.55.png (44.2 KB ) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (6)

by Ryan J Ollos, 7 years ago

comment:1 by Ryan J Ollos, 7 years ago

Proposed changes in [48594d2eb/rjollos.git].

comment:2 by Ryan J Ollos, 7 years ago

API Changes: modified (diff)

comment:3 by Ryan J Ollos, 7 years ago

The proposed changes don't work for the case of grouped results. It seems only one tfoot is allowed per table, and it must come before the tbody elements. Instead, I propose to just classify the tbody elements as either headers or results: [37481a733/rjollos.git].

comment:4 by Ryan J Ollos, 7 years ago

API Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.2-stable in [15919,15926], merged to trunk in [15920,15927].

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 7 years ago

API Changes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.