Allow permission groups to be CC'ed

[Ryan J Ollos]

Discussed in ​trac-users:Aly_eHLw7J0/GmzimnwjAAAJ. It would be useful to allow permission groups to be CC'ed, at the very least to improvise until we have a real user and group system in Trac.

trac/ticket/notification.py

@@ -29 +29 @@
 from trac.notification.mail import (RecipientMatcher, create_message_id,
                                     get_from_author, set_header)
 from trac.notification.model import Subscription
+from trac.perm import PermissionSystem
 from trac.ticket.api import translation_deactivated
 from trac.ticket.model import Ticket
 from trac.util.datefmt import (datetime_now, format_date_or_datetime,
@@ -462 +463 @@
         if 'fields' in event.changes and 'cc' in event.changes['fields']:
             cc_set.update(to_set(event.changes['fields']['cc']['old']))
 
+        # Get members of permission groups
+        groups = PermissionSystem(self.env).get_groups_dict()
+        for cc in cc_set.copy():
+            if cc in groups:
+                cc_set.remove(cc)
+                cc_set.update(groups[cc])
+
         matcher = RecipientMatcher(self.env)
         klass = self.__class__.__name__
         sids = set()

I don't see much downside to the patch provided that we don't intend to adopt a naming convention for groups later on, which could result in backward incompatible changes.

[Ryan J Ollos]

CarbonCopyGroupSubscriber.py​ implements notifications for permission group, for anyone needing an immediate solution. You can make it a default rule:

[notification-subscriber]
always_noticy_group_cc = CarbonCopyGroupSubscriber

Please ask on the MailingList, not here, if you have trouble with this single-file plugin.

[Ryan J Ollos]

I'd like to consider this patch for 1.3.6.

[Ryan J Ollos]

Proposed changes in [3b6201f06/rjollos.git].

[Ryan J Ollos]

Committed to trunk in r17046.

[Ryan J Ollos]

Documented in 1.3/TracNotification@5.