Exceptions from navigation contributor always should be logged

[Jun Omae]

Exception's message from navigation contributor is not logged. I cannot investigate issues from the contributors caused by this behavior.

trac/web/chrome.py

@@ -810 +810 @@
             except Exception, e:
                 name = contributor.__class__.__name__
                 if isinstance(e, TracError):
-                    self.log.warning("Error with navigation contributor %s",
-                                     name)
+                    self.log.warning("Error with navigation contributor %s: "
+                                     "%s", name, exception_to_unicode(e))
                 else:
                     self.log.error("Error with navigation contributor %s: %s",
-                                   name, exception_to_unicode(e))
+                                   name,
+                                   exception_to_unicode(e, traceback=True))
                 add_warning(req, _("Error with navigation contributor "
                                    '"%(name)s"', name=name))
 

For now, patch like this is applied to all contributors in my environment to catch the same issue:

diff --git a/foobar/foobar/web_ui.py b/foobar/foobar/web_ui.py
index ade158b8..44b94eb9 100644
--- a/foobar/foobar/web_ui.py
+++ b/foobar/foobar/web_ui.py
@@ -1022,6 +1022,14 @@
         return None

     def get_navigation_items(self, req):
+        try:
+            return self._get_navigation_items(req)
+        except:
+            self.log.error('Exception caught in %s', self.__class__.__name__,
+                           exc_info=True)
+            return []
+
+    def _get_navigation_items(self, req):
         ...