Error accessing the timeline

[Juanma Barranquero]

While testing the current devel version from the repository, I get an error on accessing the Timeline:

Oops...
Trac detected an internal error:

global name 'row_node' is not defined

[...]

Traceback (most recent call last):
  File "C:\bin\python\lib\site-packages\trac\web\modpython_frontend.py", line 179, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "C:\bin\python\lib\site-packages\trac\web\main.py", line 319, in dispatch_request
    module.run(req)
  File "C:\bin\python\lib\site-packages\trac\Module.py", line 49, in run
    self.render(req)
  File "C:\bin\python\lib\site-packages\trac\Timeline.py", line 153, in render
    item = render_func(req, item)
  File "C:\bin\python\lib\site-packages\trac\Timeline.py", line 205, in _render_changeset
    if not self.authzperm.has_permission(row_node['name']):
NameError: global name 'row_node' is not defined

[Christopher Lenz]

Whoa, that's mine.

[Christopher Lenz]

Should be fixed in [1338].

[Juanma Barranquero]

Not exactly:

ops...
Trac detected an internal error:

'R'

[...]

Traceback (most recent call last):
  File "C:\bin\python\lib\site-packages\trac\web\modpython_frontend.py", line 179, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "C:\bin\python\lib\site-packages\trac\web\main.py", line 319, in dispatch_request
    module.run(req)
  File "C:\bin\python\lib\site-packages\trac\Module.py", line 49, in run
    self.render(req)
  File "C:\bin\python\lib\site-packages\trac\Timeline.py", line 149, in render
    item = render_func(req, item)
  File "C:\bin\python\lib\site-packages\trac\Timeline.py", line 201, in _render_changeset
    files.append('<span class="%s">%s</span>'
KeyError: 'R'

[Christopher Lenz]

Aargh. Need. More. Coffee.

[Christopher Lenz]

[1340] should fix that, too.

Display of renames and copies sucks in the timeline, admittedly. I'm not a fan of the changeset_show_files option myself, so I'm not all too motivated in improving it.

[anonymous]

testit

[Juanma Barranquero]

It works now, thanks.

Personally I find changeset_show_files quite useful to quickly review other people's changes.