Edgewall Software

Opened 7 years ago

Last modified 7 years ago

#12727 closed defect

The revision log column labeled Age should be labeled Date when time format preference is absolute — at Version 3

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.1
Component: version control/log view Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Directory listing in Browser and Repository Log views label date column as Date when time format is absolute. The column is labeled as Age when time format is relative.

API Changes:
Internal Changes:

Description

The column is currently always labeled as Age.

Change History (3)

comment:1 by Ryan J Ollos, 7 years ago

Proposed change:

  • trac/versioncontrol/templates/revisionlog.html 

    diff --git a/trac/versioncontrol/templates/revisionlog.html b/trac/versioncontrol/templates/revisionlog.html
index 8fbf5fcc1..a523ebc73 100644
    a b  
    165165              <th class="diff" title="${_('Old / New')}">${_("Diff")}</th>
    166166              <th class="change"></th>
    167167              <th class="rev">${_("Rev")}</th>
    168               <th class="age">${_("Age")}</th>
     168              <th class="age">${_("Age") if dateinfo_format == 'relative' else _("Date")}</th>
    169169              <th class="author">${_("Author")}</th>
    170170              <th class="summary">
    171171                # if not verbose:

  • trac/web/chrome.py 

    diff --git a/trac/web/chrome.py b/trac/web/chrome.py
index 9e51d251f..0409a6a99 100644
    a b class Chrome(Component):  
    12501250
    12511251            # Date/time formatting
    12521252            'dateinfo': dateinfo,
     1253            'dateinfo_format': req.session.get('dateinfo',
     1254                                               self.default_dateinfo_format),
    12531255            'pretty_dateinfo': pretty_dateinfo,
    12541256            'format_datetime': partial(user_time, req, format_datetime),
    12551257            'format_date': partial(user_time, req, format_date),

comment:2 by Ryan J Ollos, 7 years ago

The same change is needed for directory listing like on Browser page ([87b409c6/rjollos.git]). Latest in log:rjollos.git:t12727_age_column.

comment:3 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Note: See TracTickets for help on using tickets.