Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12727 closed defect (fixed)

The revision log column labeled Age should be labeled Date when time format preference is absolute

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.1
Component: version control/log view Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Directory listing in the Browser and Revision Log views label the date column as Date when Time format is Absolute. The column is labeled as Age when Time format is Relative.

API Changes:
Internal Changes:

Description

The column is currently always labeled as Age.

Attachments (0)

Change History (6)

comment:1 by Ryan J Ollos, 7 years ago

Proposed change:

  • trac/versioncontrol/templates/revisionlog.html 

    diff --git a/trac/versioncontrol/templates/revisionlog.html b/trac/versioncontrol/templates/revisionlog.html
index 8fbf5fcc1..a523ebc73 100644
    a b  
    165165              <th class="diff" title="${_('Old / New')}">${_("Diff")}</th>
    166166              <th class="change"></th>
    167167              <th class="rev">${_("Rev")}</th>
    168               <th class="age">${_("Age")}</th>
     168              <th class="age">${_("Age") if dateinfo_format == 'relative' else _("Date")}</th>
    169169              <th class="author">${_("Author")}</th>
    170170              <th class="summary">
    171171                # if not verbose:

  • trac/web/chrome.py 

    diff --git a/trac/web/chrome.py b/trac/web/chrome.py
index 9e51d251f..0409a6a99 100644
    a b class Chrome(Component):  
    12501250
    12511251            # Date/time formatting
    12521252            'dateinfo': dateinfo,
     1253            'dateinfo_format': req.session.get('dateinfo',
     1254                                               self.default_dateinfo_format),
    12531255            'pretty_dateinfo': pretty_dateinfo,
    12541256            'format_datetime': partial(user_time, req, format_datetime),
    12551257            'format_date': partial(user_time, req, format_date),

comment:2 by Ryan J Ollos, 7 years ago

The same change is needed for directory listing like on Browser page ([87b409c6/rjollos.git]). Latest in log:rjollos.git:t12727_age_column.

comment:3 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

comment:4 by Ryan J Ollos, 7 years ago

DONE Update TracBrowser and TracRevisionLog.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Committed to 1.2-stable in r15667, merged to trunk in r15668.

Edited TracBrowser@41, and TracRevisionLog@13.

comment:6 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.