QuerySyntaxError: Query filter requires field and constraints separated by a "="

[Ryan J Ollos]

The traceback below appears in the logs when [[TicketQuery(keywords~=firefox&chrome, format=table)]].

See also #12286. I need to review this, but I think we settled on the MacroError pattern:

trac/ticket/query.py

@@ -46 +46 @@
                              add_script_data, add_stylesheet, add_warning,
                              web_context)
 from trac.wiki.api import IWikiSyntaxProvider
-from trac.wiki.formatter import system_message
+from trac.wiki.formatter import MacroError
 from trac.wiki.macros import WikiMacroBase
 
 
@@ -1354 +1354 @@
             query_string += '&'
 
         query_string += '&'.join('%s=%s' % item for item in kwargs.iteritems())
-        query = Query.from_string(self.env, query_string)
+        try:
+            query = Query.from_string(self.env, query_string)
+        except QuerySyntaxError as e:
+            raise MacroError(e)
 
         if format in ('count', 'rawcount'):
             cnt = query.count(req)
@@ -1370 +1373 @@
         try:
             tickets = query.execute(req)
         except QueryValueError as e:
-            self.log.warning(e)
-            return system_message(_("Error executing TicketQuery macro"), e)
+            raise MacroError(e)
 
         if format == 'table':
             data = query.template_data(formatter.context, tickets,

trac/wiki/formatter.py

@@ -794 +794 @@
         try:
             return macro.ensure_inline(macro.process(args))
         except MacroError as e:
-            return system_message(e)
+            return system_message(_("Macro %(name)s(%(args)s) failed",
+                                    name=name, args=args), to_unicode(e))
         except Exception as e:
             self.env.log.error('Macro %s(%s) failed:%s', name, args,
                                exception_to_unicode(e, traceback=True))

With the change, the error message would be:

Error executing TicketQuery macro

Query filter requires field and constraints separated by a "="

[pid 23603 140352200914688] 2017-02-21 11:07:53,460 Trac[formatter] ERROR: Macro TicketQuery(keywords~=firefox&chrome, format=table) failed:
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.3dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 795, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/usr/local/virtualenv/1.3dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 371, in process
    text = self.processor(text)
  File "/usr/local/virtualenv/1.3dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 343, in _macro_processor
    text)
  File "/usr/local/virtualenv/1.3dev/lib/python2.7/site-packages/trac/ticket/query.py", line 1357, in expand_macro
    query = Query.from_string(self.env, query_string)
  File "/usr/local/virtualenv/1.3dev/lib/python2.7/site-packages/trac/ticket/query.py", line 169, in from_string
    raise QuerySyntaxError(_('Query filter requires field and '
QuerySyntaxError: Query filter requires field and constraints separated by a "="

[Peter Suter]

(FWIW: I was trying to remember how ​this hidden feature works:

• firefox: 14
• chrome: 14
• firefox & chrome: 1
• firefox -chrome: 13
• chrome -firefox: 13

But I had to search for #10152 instead.)

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12697_querysyntaxrror.

[Ryan J Ollos]

Committed to 1.2-stable in r15563, merged to trunk in r15564.