Timeline shows incorrect date in heading

[Ryan J Ollos]

The server is something like +8 hours from my TZ and I've set my local timezone in preferences. The time is correct for the timeline entry but the date in the heading is +1 day. I tested the behavior with demo-1.2 and the issue isn't seen there.

[Ryan J Ollos]

Proposed changes in [3b5bec52/rjollos.git].

[Christian Boos]

Be careful, I had a regression on this already, in the Jinja branch. Around the turn of the year, key_date was format_date(date) instead of format_date(date, format='iso8601'), and we had some mix-up in the order of the days, with the January days coming after the December ones.

I just tried again with your changes, and the localization preferences set to "Date format: you language settings" and "Language: English/US":

• Mar 9, 2017:
• Mar 8, 2017:
• Mar 7, 2017:
• Mar 6, 2017:
• Mar 5, 2017:
• Mar 22, 2017: Today
• Mar 21, 2017: Yesterday
• Mar 20, 2017:
• Mar 2, 2017:
• Mar 19, 2017:
• …

[Ryan J Ollos]

Okay, we'll need to separate the presentation and sorting then. Current implementation has regressions:

• doesn't respect localization, neither timezone nor date format
• these comparisons always evaluate to false: trunk/trac/timeline/templates/timeline.html@15474:82-83#L81​, because today and yesterday are localized trunk/trac/timeline/web_ui.py@15649:146-147#L144​

[Ryan J Ollos]

The changes in [945c6277/rjollos.git] pass truncated datetime objects to the template and format the datetime object in the template. I used a truncated datetime object rather than a date object because using a date object introduces problems performing addition and subtraction between datetime and date objects.

[Ryan J Ollos]

Committed to trunk in r15713.

[Ryan J Ollos]

Regression due to r15713 reported in #12799.