EmailDistributor.resolvers option should set to include_missing=False

[Jun Omae]

EmailDistributor.resovlers returns all components which are implemented IEmailAddressResolver. The behavior is not useful. I consider we should use only configured resolvers.

>>> from trac.test import EnvironmentStub
>>> from trac.loader import load_components
>>> from trac.notification.mail import EmailDistributor
>>> from trac.notification.tests.mail import TestEmailAddressResolver
>>> env = EnvironmentStub()
>>> EmailDistributor(env).resolvers
[<Component trac.notification.mail.SessionEmailResolver>, <Component trac.notification.tests.mail.TestEmailAddressResolver>]

Also, another issue is that include_missing return the option's documentation string.

>>> EmailDistributor.resolvers.include_missing
'Comma seperated list of email resolver components in the order\n        they will be called.  If an email address is resolved, the remaining\n        resolvers will not be called.\n        '

trac/notification/mail.py

@@ -280 +280 @@
     resolvers = OrderedExtensionsOption('notification',
         'email_address_resolvers', IEmailAddressResolver,
         'SessionEmailResolver',
-        """Comma seperated list of email resolver components in the order
+        include_missing=False,
+        doc="""Comma seperated list of email resolver components in the order
         they will be called.  If an email address is resolved, the remaining
         resolvers will not be called.
         """)

[Peter Suter]

Sounds good. I think this was ​copied from Announcer.

I'm surprised the default is include_missing=True. RequestDispatcher.filters​ seems to be the only other place in Trac where that default is used. I'm not sure why that is desired.

[Jun Omae]

Thanks for the reviewing. Committed in [15354] and merged in [15355].