Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

#12608 closed defect (fixed)

ValueError: invalid literal for int() with base 10: '6-120'

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.1
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed ValueError when version or old_version argument to WikiModule not an int.

API Changes:

Description

How to Reproduce

While doing a GET operation on /wiki/TracGuide, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{u'action': u'diff',
 u'contextall': u'1',
 u'old_version': u'6-120',
 'page': u'TracGuide',
 u'version': u'6'}

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:49.0) Gecko/20100101 Firefox/49.0

System Information

Trac 1.2.dev0
Babel 2.2.0
dnspython 1.12.0
Docutils 0.12
Genshi 0.6 (with speedups)
GIT 2.1.4
httplib2 0.9.2
Mercurial 3.1.2
mod_wsgi 4.3.0 (WSGIProcessGroup trac WSGIApplicationGroup %{GLOBAL})
Pillow 3.1.0
psycopg2 2.6.1
Pygments 2.1.3
Python 2.7.9 (default, Jun 29 2016, 13:11:10)
[GCC 4.9.2]
python-oauth2 1.5.211
pytz 2016.4
setuptools 18.2
SpamBayes 1.1b2
Subversion 1.8.10 (r1615264)
jQuery 1.11.3
jQuery UI 1.11.4
jQuery Timepicker 1.5.5

Enabled Plugins

help-guide-version-notice N/A
milestone-to-version r15098
StatusFixer r6326
TracMercurial 1.0.0.5.dev0
TracSpamFilter 1.0.9.dev0
TracVote 0.5.1.dev0
TracWikiExtras 0.13.2dev-r11714
TranslatedPages 1.0.1

Interface Customization

shared-htdocs
shared-templates
site-htdocs
site-templates site.html, site_leftbox.html

Python Traceback

Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/web/main.py", line 613, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/web/main.py", line 253, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/web_ui.py", line 182, in process_request
    return self._render_diff(req, versioned_page)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/web_ui.py", line 433, in _render_diff
    old_version = int(old_version)
ValueError: invalid literal for int() with base 10: '6-120'

Attachments (1)

Screen Shot 2016-10-19 at 10.00.11.png (82.7 KB ) - added by Ryan J Ollos 3 years ago.

Download all attachments as: .zip

Change History (6)

by Ryan J Ollos, 3 years ago

comment:1 by Ryan J Ollos, 3 years ago

I was seeing a warning dialog when selecting the Create button on the error page:

We should probably change the protocol for default_tracker:

  • trac/web/main.py

    diff --git a/trac/web/main.py b/trac/web/main.py
    index d4d2316..34a4303 100644
    a b from trac.web.session import Session  
    6262#: This URL is used for semi-automatic bug reports (see
    6363#: `send_internal_error`).  Please modify it to point to your own
    6464#: Trac instance if you distribute a patched version of Trac.
    65 default_tracker = 'http://trac.edgewall.org'
     65default_tracker = 'https://trac.edgewall.org'
    6666
    6767
    6868class FakeSession(dict):

in reply to:  1 comment:2 by Ryan J Ollos, 3 years ago

Replying to Ryan J Ollos:

I was seeing a warning dialog when selecting the Create button on the error page:

Fixed in r15195, merged in r15196, r15197.

comment:3 by Ryan J Ollos, 3 years ago

Milestone: 1.0.141.2.1

comment:4 by Ryan J Ollos, 3 years ago

Release Notes: modified (diff)

Proposed changes in log:rjollos.git:t12608.

comment:5 by Ryan J Ollos, 3 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.2-stable in r15227, merged to trunk in r15228.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.