Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

#12580 closed defect (fixed)

Improving print_table() with data included newline characters

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.13
Component: general Version:
Severity: normal Keywords: macosx
Cc: Branch:
Release Notes:

Improve print_table() with newline characters.

API Changes:
Internal Changes:

Description

Currently, print_table() method doesn't work well with data included newline characters.

E.g. https://travis-ci.org/edgewall/trac/jobs/157393544#L235 (sys.version includes newline character on Mac OS X)

$ python -c 'import sys; print(repr(sys.version))'
'2.7.10 (default, Jul 14 2015, 19:46:27) \n[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)]'

Prooposed changes in [55d01beb5/jomae.git] (jomae.git@t12580).

Before the patch:

$ make python=27 status

Python: /venv/trac/py27/bin/python

  Package        Version
  --------------------------------------------------------------------------------------------------------------
  Python       : 2.7.10 (default, Jul 14 2015, 19:46:27)
  [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)]
  Setuptools   : 18.0.1
  Genshi       : 0.6 (without speedups)
  Babel        : not installed
  ...

After the patch:

$ make python=27 status

Python: /venv/trac/py27/bin/python

  Package        Version
  ---------------------------------------------------------------------
  Python       : 2.7.10 (default, Jul 14 2015, 19:46:27)
               : [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)]
  Setuptools   : 18.0.1
  Genshi       : 0.6 (without speedups)
  Babel        : not installed
  ...

Attachments (0)

Change History (4)

comment:1 by Jun Omae, 4 years ago

Keywords: macosx added; osx removed

comment:2 by Ryan J Ollos, 4 years ago

The changes look good to me and display well on OSX 10.11.6 with Python 2.7.12.

comment:3 by Jun Omae, 4 years ago

Milestone: next-stable-1.0.x1.0.13
Owner: set to Jun Omae
Release Notes: modified (diff)
Status: newassigned

Thanks for the reviewing! Committed in [15125] and merged in [15126-15127].

comment:4 by Jun Omae, 4 years ago

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.