AttributeError: 'FakeSession' object has no attribute 'as_int'

[Ryan J Ollos]

I noticed while working on #12559 that due to changes in #12446, the following can result when an exception is raised:

Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/api.py", line 710, in send_error
    data, 'text/html')
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/chrome.py", line 1138, in render_template
    if not req.session.as_int('accesskeys', 0):
AttributeError: 'FakeSession' object has no attribute 'as_int'

For example, raise an exception in get_connection:

trac/db/sqlite_backend.py

@@ -187 +187 @@
         yield 'sqlite', -1 if self.error else 1
 
     def get_connection(self, path, log=None, params={}):
+        raise Exception()
         self.required = True
         params['extensions'] = self._extensions
         if path == ':memory:':

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12561.1.

[Ryan J Ollos]

I've settled on using SessionDict for the new class: [0d27c082/rjollos.git], however I'll consider any feedback.

[Jun Omae]

rjollos.git@t12561.3 and SessionDict look good to me.

[Ryan J Ollos]

Thanks for review. Committed to 1.2-stable in r15075, merged to trunk in r15076.

[Ryan J Ollos]

Should we modify the initializer of SessionDict to have the same signature as dict, in order to avoid problems like that in ​th:r16119?

[Ryan J Ollos]

Replying to Ryan J Ollos:

Should we modify the initializer of SessionDict to have the same signature as dict, in order to avoid problems like that in ​th:r16119?

Fixed in r15311, merged to trunk in r15312.