cursor.execute() requires list or tuple for 2nd argument in bugzilla2trac.py

[Jun Omae]

I noticed this issue while reading r15012.

>>> import MySQLdb
>>> conn = MySQLdb.connect(user='root')
>>> cursor = conn.cursor()
>>> cursor.execute('SELECT %s', 'blah')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/venv/py25/lib/python2.5/site-packages/MySQLdb/cursors.py", line 187, in execute
    query = query % tuple([db.literal(item) for item in args])
TypeError: not all arguments converted during string formatting
>>> cursor.execute('SELECT %s', ['blah'])
1L
>>> list(cursor)
[('blah',)]

I think the following code should use a list and bugzilla2trac.py currently doesn't work….

     def getLoginName(self, cursor, userid):
         if userid not in self.loginNameCache:
-            cursor.execute("SELECT * FROM profiles WHERE userid = %s", (userid))
+            cursor.execute("SELECT * FROM profiles WHERE userid = %s",
+                           [userid])
             loginName = cursor.fetchall()

Untested patch: bugzilla2trac.diff​.

[Ryan J Ollos]

I think it would be a good idea to just go ahead and commit this since it looks like the script is completely broken. From the ​other open tickets it looks like there is a lot of work to do on bugzilla2trac and we could fix other problems later.

Also, we could use a tuple rather than list, (fieldid,), which seems to be the more common style used throughout the Trac codebase.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Peter Suter]

([15027] referenced this ticket instead of #9612.)

[Ryan J Ollos]

Minor fix to bugzilla2trac.py in r16664, merged in r16665, r16666.

[Ryan J Ollos]

bugzilla2trac.py is no longer maintainer by Trac developers and is being deleted from the trunk. If you need the plugin, please consider copying it from 1.4-stable​ and creating a plugin on ​trac-hacks.org.