Multiline option documentation is rendered as a oneliner

[Ryan J Ollos]

Option documentation such as [logging] log_format contains markup that should be rendered as multiple lines: tags/trac-1.0.11/trac/env.py#L241​.

With a minor change, the text could be rendered as multi-line.

trac/htdocs/css/wiki.css

@@ -119 +119 @@
  font-style: italic;
  white-space: nowrap;
 }
+div.tracini td p { margin: 0 }

trac/wiki/macros.py

@@ -807 +807 @@
              format_to_html(self.env, formatter.context, section_doc),
              tag.table(class_='wiki')(tag.tbody(
                  tag.tr(tag.td(tag.code(option.name)),
-                        tag.td(format_to_oneliner(self.env, formatter.context,
-                                                  option.doc)),
+                        tag.td(format_to_html(self.env, formatter.context,
+                                              option.doc)),
                         default_cell(option),
                         class_='odd' if idx % 2 else 'even')
                  for idx, option in

[Ryan J Ollos]

If the change is made, we may want to consider a small margin between paragraphs, and reformatting some of the option documentation. The latter point may make the change more suitable for 1.2 since changes to option documentation would require updates to l10n catalogs, and should be minimized to prevent extra work for translators.

[Jun Omae]

That looks good to me. ​IniAdminPlugin renders the documents using wiki_to_html at ​source:iniadminplugin/0.11/iniadmin/templates/iniadmin.html@13607:50#L21.

trac/htdocs/css/wiki.css

@@ -119 +119 @@
  font-style: italic;
  white-space: nowrap;
 }
+div.tracini td p { margin: 0 }

I think it might be good to use 0-margin for first and last paragraphs.

div.tracini td > p:first-child { margin-top: 0 }
div.tracini td > p:last-child { margin-bottom: 0 }

In my environment, I use 0-margin for first and last children in table cell like this.

table.wiki th > :first-child, table.wiki td > :first-child { margin-top: 0 }
table.wiki th > :last-child, table.wiki td > :last-child { margin-bottom: 0 }

[Ryan J Ollos]

0-margin for first and last looks good. Committed to 1.0-stable in r14897, merged to 1.2-stable in r14898, merged to trunk in r14899.