Python >= 2.6 should be required for recaptcha2 module

[Ryan J Ollos]

Noted while reviewing ​gmessage:trac-users:ibiYYaqNok0/Sz_Nt6eTAAAJ, plugins/1.0/spam-filter/tracspamfilter/captcha/recaptcha2.py@14630:14​ imports json, which is only available in Python ≥ 2.6.

setup.py​ requires json for the tracspamfilter.filters.blogspam module, and json requires Python ≥ 2.6.

It's possible we could address the issue found on the mailing list as well, with the following change (untested):

../spam-filter/setup.py

@@ -12 +12 @@
 # individuals. For the exact contribution history, see the revision
 # history and logs, available at http://projects.edgewall.com/trac/.
 
+import sys
 from setuptools import setup, find_packages
 
 PACKAGE = 'TracSpamFilter'
@@ -60 +61 @@
         'dns': ['dnspython>=1.3.5'],
         'spambayes': ['spambayes'],
         'pillow': ['pillow'],
-        'json': ['python>=2.6'],
+        'json': ['simplejson' if sys.version_info < (2, 6) else ''],
         'account': ['TracAccountManager >= 0.4'],
         'oauth': ['oauth2'],
         'httplib2': ['httplib2']
@@ -98 +99 @@
         spamfilter.captcha.expression = tracspamfilter.captcha.expression
         spamfilter.captcha.rand = tracspamfilter.captcha.rand
         spamfilter.captcha.recaptcha = tracspamfilter.captcha.recaptcha
-        spamfilter.captcha.recaptcha2 = tracspamfilter.captcha.recaptcha2
+        spamfilter.captcha.recaptcha2 = tracspamfilter.captcha.recaptcha2[json]
         spamfilter.captcha.keycaptcha = tracspamfilter.captcha.keycaptcha
         spamfilter.captcha.mollom = tracspamfilter.captcha.mollom[oauth,httplib2]
     """,

../spam-filter/tracspamfilter/captcha/recaptcha2.py

@@ -11 +11 @@
 # individuals. For the exact contribution history, see the revision
 # history and logs, available at http://projects.edgewall.com/trac/.
 
-import json
 import urllib
 import urllib2
 from pkg_resources import get_distribution
+try:
+    import json
+except ImportError:
+    import simplejson as json
 
 from trac import __version__ as TRAC_VERSION
 from trac.config import Option

../spam-filter/tracspamfilter/filters/blogspam.py

@@ -15 +15 @@
 # Author: Dirk Stöcker <trac@dstoecker.de>
 
 from email.Utils import parseaddr
-import json
 from pkg_resources import get_distribution
+try:
+    import json
+except ImportError:
+    import simplejson as json
 
 from trac import __version__ as TRAC_VERSION
 from trac.config import IntOption, Option, ListOption

[Jun Omae]

I noticed tracspamfilter for Trac 1.0 with Python 2.5 has syntax errors due to with keywords without from __future__ import with_statement.

[Ryan J Ollos]

Made use of with_statement Python 2.5-compatible in [14812].

[Ryan J Ollos]

The following error is shown in logs on startup, confirming the finding on the mailing list:

10:40:03 PM Trac[loader] ERROR: Skipping "spamfilter.blogspam = tracspamfilter.filters.blogspam [json]": (version conflict "VersionConflict: (Python 2.7.11- (/usr/lib/python2.7/lib-dynload), Requirement.parse('python>=2.6'))")

Also, several errors like the following:

10:40:03 PM Trac[loader] ERROR: Skipping "tracopt.perm.authz_policy = tracopt.perm.authz_policy [configobj]": 
Traceback (most recent call last):
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/trac/loader.py", line 68, in _load_eggs
    entry.load(require=True)
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2228, in load
    self.require(*args, **kwargs)
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2245, in require
    items = working_set.resolve(reqs, env, installer)
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 808, in resolve
    if not req_extras.markers_pass(req):
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 993, in markers_pass
    return not req.marker or any(extra_evals) or req.marker.evaluate()
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/_vendor/packaging/markers.py", line 278, in evaluate
    return _evaluate_markers(self._markers, current_environment)
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/_vendor/packaging/markers.py", line 203, in _evaluate_markers
    lhs_value = _get_env(environment, lhs.value)
  File "/home/user/pve-2.7/local/lib/python2.7/site-packages/pkg_resources/_vendor/packaging/markers.py", line 185, in _get_env
    "{0!r} does not exist in evaluation environment.".format(name)
UndefinedEnvironmentName: 'extra' does not exist in evaluation environment.

[Ryan J Ollos]

Fixed in [14813].