Edgewall Software
Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#12475 closed defect (fixed)

Test failure in trac.ticket.tests.functional.RegressionTestTicket4447

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Milestone: 0.12.8
Component: general Version:
Severity: normal Keywords: tests
Cc:
Release Notes:

Fixed sporadic test failure in trac.ticket.tests.functional.RegressionTestTicket4447.

API Changes:

Description

Probably due to the regex matching random word generation.

======================================================================
FAIL: runTest (trac.ticket.tests.functional.RegressionTestTicket4447)
Test for regression of http://trac.edgewall.org/ticket/4447
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/edgewall/trac/trac/ticket/tests/functional.py", line 1640, in runTest
    tc.notfind('set to')
  File "/home/travis/build/edgewall/trac/trac/tests/functional/better_twill.py", line 238, in better_notfind
    (to_unicode(e), filename))
TwillAssertionError: match to 'set to' at file:///home/travis/build/edgewall/trac/testenv/trac/log/RegressionTestTicket4447.html
----------------------------------------------------------------------
Ran 176 tests in 192.463s
FAILED (failures=1)
make: *** [functional-test] Error 1

Attachments (0)

Change History (7)

comment:1 Changed 2 years ago by Jun Omae

It seems that tc.notfind('set to') confirms not using line 102 in ticket_change.html. Then, we could modify the tests like [12155]:

  • trac/ticket/tests/functional.py

    diff --git a/trac/ticket/tests/functional.py b/trac/ticket/tests/functional.py
    index e6b0c62b2..39b1bd8b5 100755
    a b class RegressionTestTicket4447(FunctionalTwillTestCaseSetup):  
    16371637        self._tester.add_comment(ticketid)
    16381638        tc.notfind('<strong class="trac-field-newfield">Another Custom Field'
    16391639                   '</strong>[ \t\n]+<em></em>[ \t\n]+deleted')
    1640         tc.notfind('set to')
     1640        tc.notfind('<strong class="trac-field-newfield">Another Custom Field'
     1641                   '</strong>[ \t\n]*set to <em>')
    16411642
    16421643
    16431644class RegressionTestTicket4630a(FunctionalTwillTestCaseSetup):

comment:2 Changed 2 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: newassigned

Looks good. I'll commit the change.

comment:3 Changed 2 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [14758], merged to trunk in [14759].

comment:4 Changed 2 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to Jun Omae

comment:5 Changed 2 years ago by Ryan J Ollos

Milestone: 1.0.120.12.8
Release Notes: modified (diff)

Backported to 0.12-stable in [14795], to address a test failure.

comment:6 Changed 2 years ago by Jun Omae

I think we should additionally remove tc.notfind('deleted') and tc.notfind('set to') at branches/0.12-stable/trac/ticket/tests/functional.py@14795:962-963#L948 in [14795]….

comment:7 Changed 2 years ago by Ryan J Ollos

I resolved the merge conflict incorrectly. Fixed in [14803].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.