Edgewall Software
Modify

Opened 19 years ago

Closed 18 years ago

Last modified 18 years ago

#1246 closed defect (fixed)

Diff display in konqueror

Reported by: kilian.cavalotti@… Owned by: Christian Boos
Priority: lowest Milestone: 0.10
Component: general Version: 0.8
Severity: trivial Keywords: layout
Cc: kilian.cavalotti@…, maze@…, dfr@…, mjhweb-tractickets@…, trac@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In konqueror, the display of the diff table does not use the whole page width.

patch follows

--- diff.css.old        2004-12-21 02:17:36.000000000 +0100
+++ diff.css    2005-03-03 16:19:12.153776512 +0100
@@ -50,6 +50,7 @@
 /* Styles for the list of diffs */
 .diff ul { clear: both; margin: 0; padding: 0 }
 .diff li {
+ width: 100%;
  background: #f7f7f7;
  border: 1px solid #d7d7d7;
  list-style-type: none;

Another problem is that konqueror does not seems to take care of the overflow: hidden directive, but I can't figure why…

Attachments (1)

diff.css.patch (294 bytes ) - added by trac@… 18 years ago.
Patch against trunk

Download all attachments as: .zip

Change History (15)

comment:1 by Christopher Lenz, 19 years ago

Keywords: layout added
Milestone: 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Priority: normallowest
Severity: minortrivial
Status: newassigned

comment:2 by Christopher Lenz, 19 years ago

#1331 has been marked as duplicate of this ticket.

comment:3 by anonymous, 19 years ago

Cc: maze@… added

comment:4 by anonymous, 19 years ago

Cc: dfr@… added

comment:5 by Christopher Lenz, 19 years ago

Milestone: 0.90.9.1

comment:6 by Christopher Lenz, 18 years ago

Milestone: 0.9.10.9.2

comment:7 by Christopher Lenz, 18 years ago

Milestone: 0.9.30.9.4

comment:8 by anonymous, 18 years ago

Cc: mjhweb-tractickets@… added

comment:9 by dunerat@…, 18 years ago

In Konqueror (KDE 3.5.1), the display of the diff table does not use the whole page width for first diffset only. It seems, that konqueror cannot correctly process tag "float" of preference table. Width of first diffset (in Konqueror) is screen_width - legend_tab_width - preference_tab_width or screen_width - preference_tab_width.

by trac@…, 18 years ago

Attachment: diff.css.patch added

Patch against trunk

comment:10 by trac@…, 18 years ago

Cc: trac@… added

The patch in diff.css.patch fixes the problem in Konqueror 3.5.1. It's similar to the patch in the report, but taken against trunk.

comment:11 by Christopher Lenz, 18 years ago

Milestone: 0.9.40.9.5

Sorry, still not going to make it into 0.9.4… postponing again.

comment:12 by Christopher Lenz, 18 years ago

Milestone: 0.9.50.10

And again.

comment:13 by Christian Boos, 18 years ago

Owner: changed from Christopher Lenz to Christian Boos
Status: assignednew

Was there something wrong with the width: 100% fix?

That change doesn't break IExplorer, Firefox, Opera 9 preview, but I can't tell for Konqueror though.

comment:14 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

Patch applied in r3389, tentatively closing this as fixed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.