Milestone edit page says 'retargeted to milestone "None"' (None milestone is missing)

[Jun Omae]

How to reproduce:

1. Visit /milestone/milestone2 page
2. Click Edit milestone button
3. Check Completed: checkbox
4. Select None for Retarget associated open tickets to milestone: dropdown
5. Submit

Proposed ad hoc patch:

trac/ticket/roadmap.py

@@ -718 +718 @@
             add_notice(req, _('The tickets associated with milestone '
                               '"%(name)s" have been retargeted to milestone '
                               '"%(retarget)s".', name=milestone.name,
-                              retarget=retarget_to))
+                              retarget=retarget_to or ''))
             new_values = {'milestone': retarget_to}
             comment = _("Tickets retargeted after milestone deleted")
             tn = BatchTicketNotifyEmail(self.env)
@@ -805 +805 @@
                 add_notice(req, _('The open tickets associated with '
                                   'milestone "%(name)s" have been retargeted '
                                   'to milestone "%(retarget)s".',
-                                  name=milestone.name, retarget=retarget_to))
+                                  name=milestone.name,
+                                  retarget=retarget_to or ''))
                 new_values = {'milestone': retarget_to}
                 comment = comment or \
                           _("Open tickets retargeted after milestone closed")

Also, None phrase in retargeted milestone dropdown is a general word. It is difficult to translate. I think we should change to something better, e.g. no targeted milestone, etc…

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed