Test failures with Babel 2.3.1

[Ryan J Ollos]

======================================================================
ERROR: test_i18n_parse_date_roundtrip (trac.util.tests.datefmt.I18nDateFormatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1440, in test_i18n_parse_date_roundtrip
    locale=locale)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/datefmt.py", line 305, in format_datetime
    return _format_datetime(t, format, tzinfo, locale, 'datetime')
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/datefmt.py", line 285, in _format_datetime
    return babel_format_datetime(t, format, None, locale)
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 721, in format_datetime
    locale=locale)) \
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 787, in format_time
    return parse_pattern(format).apply(time, locale)
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 1208, in apply
    return self % DateTimeFormat(datetime, locale)
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 1205, in __mod__
    return self.format % other
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 1242, in __getitem__
    return self.format_period(char)
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/dates.py", line 1384, in format_period
    return get_period_names(locale=self.locale)[period]
  File "/Users/rjollos/Documents/Workspace/trac-dev/pve/lib/python2.7/site-packages/babel/localedata.py", line 207, in __getitem__
    orig = val = self._data[key]
KeyError: 'pm'

----------------------------------

[Jun Omae]

I've filed in ​https://github.com/python-babel/babel/issues/378.

[Ryan J Ollos]

Would it make sense to pin the Babel version in .travis.yml and contrib/appveyor.ps1 until a fix is available?

[Jun Omae]

That makes sense. I'll push it. Babel 2.3.0 has a packaging issue that missing babel/locale-data directory.

.travis.yml

@@ -15 +15 @@
   - mysql -u root -e "CREATE USER tracuser@localhost IDENTIFIED BY 'password';"
   - mysql -u root -e "GRANT ALL ON trac.* TO tracuser@localhost; FLUSH PRIVILEGES;"
 install:
-  - pip install -q Genshi==0.7 Babel configobj Pygments docutils lxml pytz twill==0.9.1 psycopg2 MySQL-python
+  - pip install -q Genshi==0.7 'Babel<2.3.0' configobj Pygments docutils lxml pytz twill==0.9.1 psycopg2 MySQL-python
   - echo ".uri = $TRAC_TEST_DB_URI" >Makefile.cfg
 addons:
   apt:

contrib/appveyor.ps1

@@ -54 +54 @@
 
 $pipCommonPackages = @(
     'genshi',
-    'babel',
+    'babel<2.3.0',
     'twill==0.9.1',
     'configobj',
     'docutils',

[Jun Omae]

Applied in [14694] and [14695].

[Jun Omae]

get_period_names() accepts context parameter since Babel 2.3.0. We should pass context='format' to it.

Proposed changes in jomae.git@t12445.

[Jun Omae]

Strange error: ​https://travis-ci.org/edgewall/trac/jobs/121694329

$ pip --version
pip 6.0.7 from /home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages (python 2.6)
...
$ pip install -q Genshi==0.7 'Babel<2.3.0,>=2.3.2' configobj Pygments docutils lxml pytz twill==0.9.1 psycopg2 MySQL-python
  Could not find a version that satisfies the requirement Babel<2.3.0,>=2.3.2 (from versions: 0.9.6, 1.0, 1.1, 1.2, 1.3, 2.0, 2.1.1, 2.2.0, 2.3.0, 2.3.1, 2.3.2)

  No distributions matching the version for Babel<2.3.0,>=2.3.2

With pip 1.5.4, Babel 2.3.2 is installed as expected.

$ /dev/shm/babel231/bin/pip --version
pip 1.5.4 from /dev/shm/babel231/local/lib/python2.7/site-packages (python 2.7)
$ /dev/shm/babel231/bin/pip install 'Babel<2.3.0,>=2.3.2'
Downloading/unpacking Babel<2.3.0,>=2.3.2
  Using download cache from /home/jun66j5/arc/pip/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fpy2.py3%2FB%2FBabel%2FBabel-2.3.2-py2.py3-none-any.whl
Downloading/unpacking pytz>=0a (from Babel<2.3.0,>=2.3.2)
  Using download cache from /home/jun66j5/arc/pip/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fpy2.py3%2Fp%2Fpytz%2Fpytz-2016.3-py2.py3-none-any.whl
Installing collected packages: Babel, pytz
Successfully installed Babel pytz
Cleaning up...

Hmm. Use Babel!=2.3.0,!=2.3.1 instead of Babel<2.3.0,>=2.3.2, confirmed with pip 1.5.4, 6.0.7, 7.1.2 and 8.1.1.

[Jun Omae]

Committed in [14696:14697] and merged to trunk in [14698].

[Ryan J Ollos]

Replying to Jun Omae:

get_period_names() accepts context parameter since Babel 2.3.0. We should pass context='format' to it.

In r17402, added a hint so we can remove compatibility code if support for Babel < 2.3.1 is removed.

2.3.0 was ​not released due to deployment problems, so noted it as since 2.3.1, but effectively the same. ​This is the changeset.