Raise error or log warning when auto_increment_increment is not 1

[Ryan J Ollos]

After giving further consideration to the issue documented in MySqlDb@74, I think it would be pretty straightforward and probably a good idea to raise an error or log a warning when auto_increment_increment is not 1.

mysql> SHOW VARIABLES WHERE variable_name='auto_increment_increment';
+--------------------------+-------+
| Variable_name            | Value |
+--------------------------+-------+
| auto_increment_increment | 1     |
+--------------------------+-------+
1 row in set (0.00 sec)

[Jun Omae]

I think no need.

Default of auto_increment_increment is 1. If the value is not 1, that means the database administrator intentionally have changed it. If the configuration is intentional, the logging is noisy.

Even if ticket id isn't incremented by 1, that is not a big issue. I suggest the administrator should fix after noticing that.

[Christian Boos]

Of course you could have one admin setting it that way, then someone else taking over and be surprised… but no harm done and it's now documented and easy to fix. So I agree with Jun on this one.

Besides, I have somewhere an unfinished branch where the visible ticket ID would have been distinct from its actual uid. That ID would still be checked for unicity, but it also would be a string for more flexibility (e.g. could be something like "230.2", useful for requirements or splitted "user stories", or #886 in general). In this scenario, the auto increment wouldn't matter at all as that surrogate key would never be displayed.