Add methods to EnvironmentStub to clear and restore Component registry

[Ryan J Ollos]

The proposed changes in [c5798f0c/rjollos.git] extract code from TestCase setUp methods to methods of the EnvironmentStub class.

[Ryan J Ollos]

Committed changes to 1.0-stable in [14602], merged in [14603].

Would the following changes make also sense?: log:rjollos.git:t12405_clear_restore_registry.1.

[Christian Boos]

Replying to Ryan J Ollos:

Would the following changes make also sense?: log:rjollos.git:t12405_clear_restore_registry.1.

I think it's better to keep trac/tests/core.py with as little external dependencies as possible. If something goes wrong in a test there, we can just focus on the trac.core part, not worry about the EnvironmentStub or the whole trac.env layer. trac.core is pretty unique in that, as for nearly everything else trac.env would be a necessary dependency and then it's not a big deal to also depend on EnvironmentStub.

Think about people stealing our lovely component architecture, they can just grab trac.core, trac.tests.core ;-)

[Ryan J Ollos]

That makes sense, I'll discard the change [7cb41fe5/rjollos.git].

I'm not very familiar with the Component architecture, but I'm wondering if it make sense to save/restore the ComponentMeta._components along with ComponentMeta._registry: [b94c1318/rjollos.git]. Are any use cases foreseen?

[Ryan J Ollos]

Additional changes on 1.0-stable in [14639], merged to trunk in [14640].