Error message with untranslated text when removing no selected items

[Jun Omae]

In /admin/ticket/priority page, Remove selected items with no selection shows the following message in French.

Aucun priority sélectionné

priority text is untranslated….

2016-02-26 19:27:04,572 Trac[main] WARNING: [192.168.11.11] HTTPInternalError: 500 Erreur Trac (Aucun priority sélectionné)

It would be good to add localized message for each enum of ticket.

trac/ticket/admin.py

@@ -599 +599 @@
 
     _type = 'unknown'
     _enum_cls = None
+    _no_item_selected = None
 
     # TicketAdminPanel methods
 
@@ -651 +652 @@
                 elif req.args.get('remove'):
                     sel = req.args.get('sel')
                     if not sel:
-                        raise TracError(_("No %s selected") % self._type)
+                        raise TracError(gettext(self._no_item_selected))
                     if not isinstance(sel, list):
                         sel = [sel]
                     with self.env.db_transaction:
@@ -789 +790 @@
     _type = 'priority'
     _enum_cls = model.Priority
     _label = (N_('Priority'), N_('Priorities'))
+    _no_item_selected = N_("No priority selected")
 
 
 class ResolutionAdminPanel(AbstractEnumAdminPanel):
     _type = 'resolution'
     _enum_cls = model.Resolution
     _label = (N_('Resolution'), N_('Resolutions'))
+    _no_item_selected = N_("No resolution selected")
 
 
 class SeverityAdminPanel(AbstractEnumAdminPanel):
     _type = 'severity'
     _enum_cls = model.Severity
     _label = (N_('Severity'), N_('Severities'))
+    _no_item_selected = N_("No severity selected")
 
 
 class TicketTypeAdminPanel(AbstractEnumAdminPanel):
     _type = 'type'
     _enum_cls = model.Type
     _label = (N_('Ticket Type'), N_('Ticket Types'))
+    _no_item_selected = N_("No ticket type selected")
 
     _command_type = 'ticket_type'
     _command_help = {

[Christian Boos]

It's probably a good intermediate step until we finally tackle the TracDev/Proposals/ConfigEnumTranslation issue.

[Ryan J Ollos]

This is an aside related to one of the lines that has been changed in the proposed patch. The line is:

_("No %s selected") % self._type

whereas usually we would write that as:

_("No %(type)s selected", type=self._type)

I imagine that %(type)s is a better hint to translations, as opposed to %s. Are there any other impacts of using the former rather than the latter?

One reason I ask is that I see the former pattern used at many places in SpamFilter. One such place I corrected in [14836], to follow the more typical pattern we see in Trac. However, I was unable to find any positive or negative functional effects of this change.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed