Now button in datetime picker use wrong time when timezones are different between Trac and browser

[Jun Omae]

Now button in datetime picker uses Date() with browser's timezone to fill. If a user configure different timezone, the datetime picker fills wrong time.

This issue would be fixed by the following patch with jQuery-Timepicker-Addon v1.6.0. v1.5.5 is used in trunk.

trac/web/chrome.py

@@ -1379 +1379 @@
         is_iso8601 = req.lc_time == 'iso8601'
         now = datetime_now(req.tz)
         tzoffset = now.strftime('%z')
-        if is_iso8601:
-            default_timezone = (-1 if tzoffset.startswith('-') else 1) * \
-                               (int(tzoffset[1:3]) * 60 + int(tzoffset[3:5]))
-            timezone_list = get_timezone_list_jquery_ui(now)
-        else:
-            default_timezone = None
-            timezone_list = None
+        default_timezone = (-1 if tzoffset.startswith('-') else 1) * \
+                           (int(tzoffset[1:3]) * 60 + int(tzoffset[3:5]))
+        timezone_list = get_timezone_list_jquery_ui(now) \
+                        if is_iso8601 else None
         add_script_data(req, jquery_ui={
             'month_names': get_month_names_jquery_ui(req),
             'day_names': get_day_names_jquery_ui(req),

See also ​https://github.com/trentrichardson/jQuery-Timepicker-Addon/commit/47dbb0f8adb6a1f77bb4806ffb651c4e96849914.