Now button in datetime picker use wrong time when timezones are different between Trac and browser

[Jun Omae]

Now button in datetime picker uses Date() with browser's timezone to fill. If a user configure different timezone, the datetime picker fills wrong time.

This issue would be fixed by the following patch with jQuery-Timepicker-Addon v1.6.0. v1.5.5 is used in trunk.

trac/web/chrome.py

@@ -1379 +1379 @@
         is_iso8601 = req.lc_time == 'iso8601'
         now = datetime_now(req.tz)
         tzoffset = now.strftime('%z')
-        if is_iso8601:
-            default_timezone = (-1 if tzoffset.startswith('-') else 1) * \
-                               (int(tzoffset[1:3]) * 60 + int(tzoffset[3:5]))
-            timezone_list = get_timezone_list_jquery_ui(now)
-        else:
-            default_timezone = None
-            timezone_list = None
+        default_timezone = (-1 if tzoffset.startswith('-') else 1) * \
+                           (int(tzoffset[1:3]) * 60 + int(tzoffset[3:5]))
+        timezone_list = get_timezone_list_jquery_ui(now) \
+                        if is_iso8601 else None
         add_script_data(req, jquery_ui={
             'month_names': get_month_names_jquery_ui(req),
             'day_names': get_day_names_jquery_ui(req),

See also ​https://github.com/trentrichardson/jQuery-Timepicker-Addon/commit/47dbb0f8adb6a1f77bb4806ffb651c4e96849914.

[Ryan J Ollos]

Replying to Jun Omae:

This issue would be fixed by the following patch with jQuery-Timepicker-Addon v1.6.0. v1.5.5 is used in trunk.

It seems like a good idea to update the addon again before we release Trac 1.2. We could also consider moving from jQuery 1.11.3 to 1.12.0. jQuery UI 1.11.4 is still the latest.

[Jun Omae]

Okay. Updated log:jomae.git@t12348 with jQuery 1.12.0 and also jQuery-Timepicker-Addon 1.6.1 (latest).

[Ryan J Ollos]

I did some testing with Chrome 48 and found two minor issues that are not present on the trunk:

• The Today button on the datepicker is not effective.
• On attempting to manually edit a datetime (e.g. Milestone edit page), focus is lost after editing a single character. This even happens when deleting a single character.

[Jun Omae]

Another issue: Now button works well first time. However, it fills incorrect time on clicking it once again. It needs more tests….

[Ryan J Ollos]

jQuery 1.12.1 ​released today.

[Ryan J Ollos]

Milestone renamed

[Ryan J Ollos]

jQuery 1.12.4 is now the ​latest.

[Jun Omae]

Rebased jomae.git@t12348 and updated to jQuery 1.12.4 and jQuery-Timepicker-Addon 1.6.3. The issue in comment:5 has been fixed. However, Today button in datepicker isn't still working.

I tried datepicker without timepicker addon on ​http://jqueryui.com/datepicker/#buttonbar. The Today button in original datepicker doesn't work….

[Ryan J Ollos]

I haven't tested the comment:10 branch, but to summarize we are currently using jQuery 1.11.3 (lastest release on 1.11.x line) and jQuery UI 1.11.4 (the latest jQuery UI). If the Today button breaks with jQuery 1.12.4 (the latest release of the 1.x line), then I guess there must be a compatibility problem between jQuery UI 1.11.4 and jQuery 1.12.4?

I suppose sticking with jQuery 1.11.3 is not so bad, but it would be really nice to move to the latest jQuery 1.x by Trac 1.2, considering that in the past we've only upgraded jQuery to a major release on a major release of Trac.

I will try to spend some time on it before the weekend, since I hope to create 1.2rc1 this weekend.

[Christian Boos]

Moving to some later 1.3.x version.

[Ryan J Ollos]

Moving to 1.3.3 since we should upgrade jQuery and jQuery UI before releasing Trac 1.4.

[Ryan J Ollos]

Replying to Jun Omae:

Rebased jomae.git@t12348 and updated to jQuery 1.12.4 and jQuery-Timepicker-Addon 1.6.3. The issue in comment:5 has been fixed. However, Today button in datepicker isn't still working.

Discussed in ​SO:1076274/121694. The solution in ​SO:10094319/121694 looks good to me.

Changes rebased and jQuery-UI updated in log:rjollos.git:t12348.1. I'll do more testing. I'd like to commit the changes soon so that we have as much testing time as possible before the release of Trac 1.4.

[Jun Omae]

font-family in jquery-ui.css has many backslash characters:

$ git grep font-family: t12348.1:trac/htdocs/css/jquery-ui/jquery-ui.css
t12348.1:trac/htdocs/css/jquery-ui/jquery-ui.css:       font-family: Verdana,Arial,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\'Bitstream Vera Sans\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\',Helvetica,sans-serif;
t12348.1:trac/htdocs/css/jquery-ui/jquery-ui.css:       font-family: Verdana,Arial,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\'Bitstream Vera Sans\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\',Helvetica,sans-serif;

[Ryan J Ollos]

Issue was fixed previously in r11685. Fixed in TracDev/JavaScript@13 and [fc0f1de0/rjollos.git].

[Ryan J Ollos]

Committed to trunk in [16094:16095].