Modify ↓
Opened 10 years ago
Closed 10 years ago
#12344 closed defect (fixed)
Datetime picker is not available for time field with relative format
| Reported by: | Jun Omae | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2 |
| Component: | ticket system | Version: | |
| Severity: | normal | Keywords: | datepicker |
| Cc: | Branch: | ||
| Release Notes: |
Fix not working datetime picker for time field with relative format. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
Cause trac-relativepicker class is used.
<input type="text" id="field-verified_at" title="y/MM/dd H:mm:ss" name="field_verified_at"
value="2016/01/01 9:00:00"
class="trac-relativepicker" />
Attachments (0)
Change History (4)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
Thanks. I think we should use trac-datetimepicker for relative time fields.
-
trac/ticket/templates/ticket.html
diff --git a/trac/ticket/templates/ticket.html b/trac/ticket/templates/ticket.html index ec84ccae2..831012787 100644
a b ${value}</textarea> 272 272 checked="${value == option or None}" /> 273 273 ${option} 274 274 </label> 275 <input py:when="'time'" type="text" id="field-${field.name}" title="${field.format_hint}" 276 name="field_${field.name}" value="${field.edit}" class="trac-${field.format}picker" /> 275 <input py:when="'time'" 276 type="text" id="field-${field.name}" title="${field.format_hint}" 277 name="field_${field.name}" value="${field.edit}" 278 class="trac-${'date' if field.format == 'date' else 'datetime'}picker" /> 277 279 <py:otherwise><!--! Text input fields --> 278 280 <py:choose> 279 281 <!--! Special case for Cc: field -->
comment:4 by , 10 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Thanks for the review! Committed in [14534].
Note:
See TracTickets
for help on using tickets.



Prior to [12373], the class would have been
relativepicker. I guess issue might be due to original implementation in [11333] though.