UnboundLocalError: local variable 'template' referenced before assignment

[Ryan J Ollos]

Found in the logs:

2016-01-29 04:29:19,755 Trac[main] ERROR: Internal Server Error: <RequestWithSession "POST '/report/1'">, referrer NoneTraceback (most recent call last):
  File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/web/main.py", line 554, in _dispatch_request
    dispatcher.dispatch(req)
  File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/srv/trac-hacks.org/pve/lib/python2.7/site-packages/trac/ticket/report.py", line 209, in process_request
    return template, data, None
UnboundLocalError: local variable 'template' referenced before assignment

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12340_template_referenced_before_assignment.

There are 3 other IRequestHandler implementations that I'll fix in the same way:

• tags/trac-1.0.9/trac/attachment.py@:527-531#L512​
• tags/trac-1.0.9/trac/ticket/roadmap.py@:681-690#L665​
• tags/trac-1.0.9/trac/wiki/web_ui.py@:143-170#L134​

[Jun Omae]

Replying to Ryan J Ollos:

Proposed changes in log:rjollos.git:t12340_template_referenced_before_assignment.

We already have "Invalid request arguments." message. It might be good to use "Invalid request arguments." rather than "Invalid %(method)s request." as a new message.

[Ryan J Ollos]

Replying to Jun Omae:

We already have "Invalid request arguments." message. It might be good to use "Invalid request arguments." rather than "Invalid %(method)s request." as a new message.

Thanks for reviewing. I'll make that change before committing.

[Ryan J Ollos]

Committed to 1.0-stable in [14520], merged to trunk in [14521].