Message "do so now" may not be a valid login link

[Ryan J Ollos]

Discussed in ​trac-github#95, the link in the message You are currently not logged in. You may want to do so now. won't direct to the login link when using trac-github plugin. This will be the case whenever login is handled at a path other than /login, and in the case of the Django site they have multiple login links. The message is generated in _send_user_error​.

Is the message You may want to do so now with the link to /login very useful since the login link is so easily found on the metanav? I'm okay with closing as wontfix, but hoping to get some feedback.

[Christian Boos]

Well, if the metanav data has the correct value, maybe we can try to fetch the value from there.

[Ryan J Ollos]

I've thought about it some more. I think the only reason to not use /login as the path is the case of multiple login methods, like ​the Django project has. With multiple login links on the metanav, which do you choose? I would assume that the path at /login is the "primary" login method, but I guess that's not a good assumption because plugins will be working around Trac's use of /login for LoginModule.

I have an ​idea on how to move forward the particular issue I'm having with trac-github.

However, I'm still interested in implementing a more general solution in this ticket. The general solution could involve adding primary and alternate classes to the login links on the metanav, and using the primary link in the error message. Maybe that could be configured like this:

[metanav]
login.class = alternate
github_login.class = primary

For this case the /login link would have class alternate and the ​/github/login link would have class primary. This might be a bit overly complex and too much of an edge case for Trac to bother with though.

What if instead there was some way the user/plugin could customize _send_user_error​?

[Jun Omae]

The /login link is also used for rss feed link (searching auth_link). I think the site should disable authentication for the /login and the plugin should redirect to /github/login for the /login.

I misunderstood. Please ignore it.

[Ryan J Ollos]

The solution implemented for trac-github plugin is an option [github] auth_path_prefix, which defaults to /github. If GitHubLoginModule is the only authenticator then auth_path_prefix can be set to /.