Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12327 closed defect (fixed)

log preferences can't be updated when viewing revision ranges

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.0.10
Component: version control/log view Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Log preferences can be updated again when viewing revision ranges

API Changes:
Internal Changes:

Description

For e.g. log:branches/1.0-stable?revs=14482-14483, we generated the following HTML: 

<form id="prefs" action="" method="get">
        <div>
          <input type="hidden" name="action" value="stop_on_copy">
          <input type="hidden" name="revs" value="<trac.versioncontrol.web_ui.log.RevRanges object at 0x7fd9da09a210>">
                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Needless to say, pressing Update will lead to an error page.

(0.12-stable doesn't have the problem, 1.0-stable and trunk do)

Attachments (0)

Change History (3)

comment:1 by Christian Boos, 10 years ago

Owner: set to Christian Boos
Status: new → assigned

Aha! Didn't know about r13919 (slowly catching up with the great stuff that happened while I was off duty ;-) ).

Fix should be trivial:

  • revisionlog.html

     
    4040      <form id="prefs" action="" method="get">
    4141        <div>
    4242          <input type="hidden" name="action" value="$mode" />
    43           <input type="hidden" name="revs" value="${str(revranges)}" py:if="revranges" />
     43          <input type="hidden" name="revs" value="${unicode(revranges)}" py:if="revranges" />
    4444          <div class="choice">
    4545            <fieldset>
    4646              <legend>Revision Log Mode:</legend>

comment:2 by Christian Boos, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Fix committed in [14487], merged to trunk in [14488].

comment:3 by Jun Omae, 10 years ago

Thanks for the catching it and fixing!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.