blame detail panel no longer shows up correctly

[Christian Boos]

The following snippet no longer works with the jQuery version we're now using (v1.11.3):

            // workaround non-clickable "Close" issue in Firefox
            if ($.browser.mozilla || $.browser.webkit)
              message.find("div.inlinebuttons").next().css("clear", "right");

The JavaScript console shows:

Uncaught TypeError: Cannot read property 'mozilla' of undefined  

1.0-stable still has jQuery v1.7.2, so it still works fine there.

Note that the workaround in question is probably no longer necessary.

[Christian Boos]

Of course, all the other uses of $.browser need to be fixed as well. Just saw that the switch from table diff to unified diff in the diff wiki processor is also broken due to this problem ( var sep = $.browser.msie ? "\r" : "\n"; line 98 in diff.js).

[Christian Boos]

Proposed clean-up in log:cboos.git@t12314.

[Ryan J Ollos]

Replying to Christian Boos:

Just saw that the switch from table diff to unified diff in the diff wiki processor is also broken due to this problem ( var sep = $.browser.msie ? "\r" : "\n"; line 98 in diff.js).

Certainly related, but just thought I'd mention the same issue occurs in changeset view, switching between Tabular and Unified. Your changes fix all noted issues, tested with Chrome 48, Firefox 43.0.4 and Safari 9.0.2 on Mac OSX.

[Christian Boos]

Thanks for testing on these browsers!

Committed in r14495.

[Cinc-th]

Shouldn't the API changes read

Note that our jQuery JavaScript code should not make use of $.browser anymore.? (emphasis mine)