Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12314 closed defect (fixed)

blame detail panel no longer shows up correctly

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.2
Component: version control/browser Version: 1.2dev
Severity: normal Keywords: javascript
Cc: Branch:
Release Notes:

Support jQuery v1.11.3.

API Changes:

Note that our jQuery JavaScript code should not make use of $.browser anymore.

Internal Changes:

Description

The following snippet no longer works with the jQuery version we're now using (v1.11.3):

            // workaround non-clickable "Close" issue in Firefox
            if ($.browser.mozilla || $.browser.webkit)
              message.find("div.inlinebuttons").next().css("clear", "right");

The JavaScript console shows:

Uncaught TypeError: Cannot read property 'mozilla' of undefined  

1.0-stable still has jQuery v1.7.2, so it still works fine there.

Note that the workaround in question is probably no longer necessary.

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 5 years ago

Of course, all the other uses of $.browser need to be fixed as well. Just saw that the switch from table diff to unified diff in the diff wiki processor is also broken due to this problem ( var sep = $.browser.msie ? "\r" : "\n"; line 98 in diff.js).

comment:2 by Christian Boos, 5 years ago

Proposed clean-up in log:cboos.git@t12314.

in reply to:  1 comment:3 by Ryan J Ollos, 5 years ago

Replying to Christian Boos:

Just saw that the switch from table diff to unified diff in the diff wiki processor is also broken due to this problem ( var sep = $.browser.msie ? "\r" : "\n"; line 98 in diff.js).

Certainly related, but just thought I'd mention the same issue occurs in changeset view, switching between Tabular and Unified. Your changes fix all noted issues, tested with Chrome 48, Firefox 43.0.4 and Safari 9.0.2 on Mac OSX.

comment:4 by Christian Boos, 5 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for testing on these browsers!

Committed in r14495.

comment:5 by Cinc-th, 5 years ago

Shouldn't the API changes read

Note that our jQuery JavaScript code should not make use of $.browser anymore.? (emphasis mine)

comment:6 by Ryan J Ollos, 5 years ago

API Changes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.