Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12278 closed enhancement (fixed)

Relocate deploy_trac scripts

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2
Component: web frontend Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Removed scripts in contrib/cgi-bin, which were equivalent to the scripts created by TracAdmin deploy.

API Changes:

Moved the deploy_trac.* scripts to trac/web/templates.

Internal Changes:

Description

In [11924] (comment:3:ticket:11103) we moved admin templates associated with the ticket module from trac/admin/templates to trac/ticket/templates. Similarly, I propose to move deploy_trac.cgi, deploy_trac.wsgi and deploy_trac.fcgi from trac/admin/templates to trac/web/templates.

If the change is agreed upon, which Component in trac.web should implement ITemplateProvider? Should it be RequestDispatcher? Or perhaps a class in trac.env such as Environment, EnvironmentAdmin or EnvironmentSetup?

Also, is there any purpose to retaining the scripts in tags/trac-1.0.9/contrib/cgi-bin? The scripts are just minimal versions of the deploy_trac.* scripts that I propose to move. They were moved in [10974].

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 5 years ago

Owner: set to Ryan J Ollos
Status: newassigned

Proposed changes in log:rjollos.git:t12278_relocate_deploy_trac.

I also considered putting the deploy_trac.* scripts in trac/templates and implementing ITemplateProvider in trac.env.EnvironmentAdmin. I appreciate hearing any opinions on the best location.

comment:2 by Ryan J Ollos, 5 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to trunk in [14383:14384].

comment:3 by Ryan J Ollos, 5 years ago

API Changes: modified (diff)
Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.