Opened 8 years ago
Closed 8 years ago
Last modified 7 years ago
#12249 closed defect (fixed)
Full email address is displayed in quoted replies
|Reported by:||Owned by:||Ryan J Ollos|
Fixed regression in which author was not always obfuscated in a quoted ticket comment reply.
Description (last modified by )
Regarding to the reply in comment:19:ticket:7628, the full email address (
email@example.com) is displayed in the quoted reply, though it's obfuscated in most other places.
Change History (8)
comment:1 by , 8 years ago
|Status:||new → assigned|
comment:2 by , 8 years ago
|Summary:||full email address is occasionally displayed even when show_email_addresses is false → Full email address is displayed in quoted replies|
comment:3 by , 8 years ago
comment:4 by , 8 years ago
I made an error in [14248#file5]. The email address should always be obfuscated using
diff --git a/trac/ticket/web_ui.py b/trac/ticket/web_ui.py index 78ff6de..7a0a5c0 100644
a b from trac.util.datefmt import ( 46 46 ) 47 47 from trac.util.html import to_fragment 48 48 from trac.util.text import ( 49 exception_to_unicode, empty, is_obfuscated, shorten_line 49 exception_to_unicode, empty, is_obfuscated, obfuscate_email_address, 50 shorten_line 50 51 ) 51 52 from trac.util.presentation import separated 52 53 from trac.util.translation import _, tag_, tagn_, N_, ngettext … … class TicketModule(Component): 1678 1679 1679 1680 def quote_original(author, original, link): 1680 1681 if 'comment' not in req.args: # i.e. comment was not yet edited 1681 formatted_author = Chrome(self.env).format_author(req,author) 1682 author) 1682 1683 data['comment'] = '\n'.join( 1683 ["Replying to [%s %s]:" % (link, formatted_author)] + 1684 ["Replying to [%s %s]:" % (link, ted_author)] + 1684 1685 ["> %s" % line for line in original.splitlines()] + ['']) 1685 1686 1686 1687 if replyto == 'description':
comment:5 by , 8 years ago
|Release Notes:||modified (diff)|
|Status:||assigned → closed|
Fixed in . Thanks for spotting the issue Walty.
comment:6 by , 8 years ago
t.e.o has been updated to , so the issue should be resolved on this site.
comment:7 by , 7 years ago
Related issue in #12271.
comment:8 by , 7 years ago
|Component:||general → ticket system|
The issue occurs when the commenter has
EMAIL_VIEWand posts a quoted reply.