Full email address is displayed in quoted replies

[walty <walty8@…>]

Regarding to the reply in comment:19:ticket:7628, the full email address (walty8@gmail.com) is displayed in the quoted reply, though it's obfuscated in most other places.

[Ryan J Ollos]

The issue occurs when the commenter has EMAIL_VIEW and posts a quoted reply.

[Ryan J Ollos]

I made an error in [14248#file5]. The email address should always be obfuscated using obfuscate_email_address.

trac/ticket/web_ui.py

@@ -46 +46 @@
 )
 from trac.util.html import to_fragment
 from trac.util.text import (
-    exception_to_unicode, empty, is_obfuscated, shorten_line
+    exception_to_unicode, empty, is_obfuscated, obfuscate_email_address,
+    shorten_line
 )
 from trac.util.presentation import separated
 from trac.util.translation import _, tag_, tagn_, N_, ngettext
@@ -1678 +1679 @@
 
         def quote_original(author, original, link):
             if 'comment' not in req.args:  # i.e. comment was not yet edited
-                formatted_author = Chrome(self.env).format_author(req, author)
+                obfuscated_author = obfuscate_email_address(author)
                 data['comment'] = '\n'.join(
-                    ["Replying to [%s %s]:" % (link, formatted_author)] +
+                    ["Replying to [%s %s]:" % (link, obfuscated_author)] +
                     ["> %s" % line for line in original.splitlines()] + [''])
 
         if replyto == 'description':

[Ryan J Ollos]

Fixed in [14371]. Thanks for spotting the issue Walty.

[Ryan J Ollos]

t.e.o has been updated to [14371], so the issue should be resolved on this site.

[Ryan J Ollos]

Related issue in #12271.