Edgewall Software

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12249 closed defect (fixed)

Full email address is displayed in quoted replies

Reported by: walty <walty8@…> Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed regression in which author was not always obfuscated in a quoted ticket comment reply.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Regarding to the reply in comment:19:ticket:7628, the full email address (walty8@gmail.com) is displayed in the quoted reply, though it's obfuscated in most other places.

Attachments (0)

Change History (8)

comment:1 by Ryan J Ollos, 8 years ago

Description: modified (diff)
Owner: set to Ryan J Ollos
Status: newassigned

comment:2 by Ryan J Ollos, 8 years ago

Summary: full email address is occasionally displayed even when show_email_addresses is falseFull email address is displayed in quoted replies

comment:3 by Ryan J Ollos, 8 years ago

The issue occurs when the commenter has EMAIL_VIEW and posts a quoted reply.

Last edited 8 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Ryan J Ollos, 8 years ago

I made an error in [14248#file5]. The email address should always be obfuscated using obfuscate_email_address.

  • trac/ticket/web_ui.py

    diff --git a/trac/ticket/web_ui.py b/trac/ticket/web_ui.py
    index 78ff6de..7a0a5c0 100644
    a b from trac.util.datefmt import (  
    4747from trac.util.html import to_fragment
    4848from trac.util.text import (
    49     exception_to_unicode, empty, is_obfuscated, shorten_line
     49    exception_to_unicode, empty, is_obfuscated, obfuscate_email_address,
     50    shorten_line
    5152from trac.util.presentation import separated
    5253from trac.util.translation import _, tag_, tagn_, N_, ngettext
    class TicketModule(Component):  
    16791680        def quote_original(author, original, link):
    16801681            if 'comment' not in req.args:  # i.e. comment was not yet edited
    1681                 formatted_author = Chrome(self.env).format_author(req, author)
     1682                obfuscated_author = obfuscate_email_address(author)
    16821683                data['comment'] = '\n'.join(
    1683                     ["Replying to [%s %s]:" % (link, formatted_author)] +
     1684                    ["Replying to [%s %s]:" % (link, obfuscated_author)] +
    16841685                    ["> %s" % line for line in original.splitlines()] + [''])
    16861687        if replyto == 'description':
Last edited 8 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 8 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Fixed in [14371]. Thanks for spotting the issue Walty.

comment:6 by Ryan J Ollos, 8 years ago

t.e.o has been updated to [14371], so the issue should be resolved on this site.

comment:7 by Ryan J Ollos, 7 years ago

Related issue in #12271.

comment:8 by Ryan J Ollos, 7 years ago

Component: generalticket system

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.