Suppress "Remove useless key" warnings

[Ryan J Ollos]

When I review the logs each day I see many instances of the following:

2015-11-10 09:43:57,765 Trac[api] WARNING: Remove useless key: captcha_reject_count
2015-11-10 09:43:57,766 Trac[api] WARNING: Remove useless key: captcha_expected

Is there any value to logging a warning here? If not, maybe we could change it to log at INFO level:

tracspamfilter/captcha/api.py

@@ -197 +197 @@
                                 keys = req.session.keys()
                                 for key in keys:
                                     if key.startswith('captcha_'):
-                                        self.log.warning("Remove useless key: "
-                                                         "%s", key)
+                                        self.log.info("Remove useless key: "
+                                                      "%s", key)
                                         del req.session[key]
                                 handler = newhandler
                                 break

[Dirk Stöcker]

No objections.

[Ryan J Ollos]

Thank you for the fast reply. Committed in [14363].

[Ryan J Ollos]

Clarified warnings logged from FSpamList in [14841]. After the changes, the following is seen in the logs:

2016-06-14 10:13:46,633 Trac[fspamlist] WARNING: Error parsing response from FSpamList: syntax error: line 1, column 0
Response:
MySQL connection error. Please try again later or contact the administrator.