Edgewall Software
Modify

Opened 4 years ago

Closed 3 years ago

#12231 closed enhancement (fixed)

Add is_authenticated property to Request class

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.2
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Added is_authenticated method to Request class.

Description

The proposed change is a minor simplification motivated by this comment: tags/trac-1.0.9/trac/web/auth.py@:202#L193. The is_authenticated property should make the code slightly more clear, but I ask for comments on whether or not others feel the change makes things more clear.

Attachments (0)

Change History (9)

comment:1 by Ryan J Ollos, 4 years ago

comment:2 by Cinc-th, 4 years ago

Just my 2 cents. I think the code better shows what's going on with the changes.

A nice benefit may be that the term anonymous can easier be translated in the future.

in reply to:  2 comment:3 by Jun Omae, 4 years ago

A nice benefit may be that the term anonymous can easier be translated in the future.

No. I don't think we should do it. We should translate only when anonymous is displayed.

comment:4 by Ryan J Ollos, 4 years ago

Right, if you need anonymous to be translated when you display it to the user you can use Chrome.authorinfo or Chrome.format_author. Both have been improved by 1.1.6.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Cinc-th, 4 years ago

Thnx for the info.

comment:6 by Ryan J Ollos, 4 years ago

Milestone: 1.2
Resolution: wontfix
Status: assignedclosed

I don't think this is very useful, so closing.

comment:7 by Ryan J Ollos, 3 years ago

Milestone: 1.3.2
Resolution: wontfix
Status: closedreopened

Discussed in #12719, we'll move ahead with these changes.

comment:8 by Ryan J Ollos, 3 years ago

Status: reopenedassigned

comment:9 by Ryan J Ollos, 3 years ago

API Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Fixed in r15682.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.