Opened 9 years ago
Closed 9 years ago
#12224 closed enhancement (fixed)
Hide Format hints when datetimepicker is present
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.2 |
Component: | general | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Datetime format hints are hidden when JavaScript is enabled. |
||
API Changes: | |||
Internal Changes: |
Description
Fields that display a datetimepicker have an adjacent Format string. The string may have had a purpose before the datetimepicker was added (Trac < 1.0), but serves little purpose now. We could hide the strings using jQuery so that the strings are still present for as a no-javascript fallback.
Attachments (0)
Change History (4)
comment:1 by , 9 years ago
Owner: | set to |
---|---|
Release Notes: | modified (diff) |
Status: | new → assigned |
comment:2 by , 9 years ago
Milestone: | next-dev-1.1.x → 1.2 |
---|
comment:3 by , 9 years ago
It would be good to add class to the container element in the same way as Hide help links feature in preferences instead of directly hiding hints.
-
trac/htdocs/css/trac.css
diff --git a/trac/htdocs/css/trac.css b/trac/htdocs/css/trac.css index be3cd76a3..641377685 100644
a b div.trac-content { 447 447 #help :link, #help :visited { cursor: help } 448 448 #help hr { display: none } 449 449 450 /* Datepicker hints */ 451 .trac-nodatetimehint .trac-datetimehint { display: none } 452 450 453 /* Section folding */ 451 454 .foldable :link, .foldable :visited { 452 455 background: url(../expanded.png) 4px 50% no-repeat; -
trac/templates/layout.html
diff --git a/trac/templates/layout.html b/trac/templates/layout.html index 664d365d6..b89cb022f 100644
a b 64 64 if ($.ui) { /* is jquery-ui added? */ 65 65 $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker(); 66 66 $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker(); 67 $(" .trac-datetimehint").hide();67 $("#main").addClass("trac-nodatetimehint"); 68 68 } 69 69 $(".trac-disable").disableSubmit(".trac-disable-determinant"); 70 70 setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1);
comment:4 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks for reviewing. Committed to trunk with suggested changes in [14345:14347].
Proposed changes in log:rjollos.git:t12224-hide-datetime-format-hints.