Timezone list is incorrect after upgrading timepicker to 1.5.5

[Ryan J Ollos]

jQuery UI Timepicker was upgraded to 1.5.5 in #11019. [object Object] is displayed for the UTC entry in the timepicker's timezone list rather than Z when the format is ISO8601. See discussion in comment:6:ticket:11413.

The proposed patch also provides some minor improvements when directly editing the timepicker text field, although issues still remain in which the cursor will move to the end of the line while attempting to make an edit.

[Ryan J Ollos]

Patch by Jun from #11413.

[Ryan J Ollos]

I'm not so familiar with the specifics of these date and time formats so I'll ask - was it intentional to change the label for +00:00 to Z?

On 1.0-stable the label is +00:00 and the value is Z.

[Ryan J Ollos]

Another potential issue, which is also seen on 1.0-stable - when clicking on an empty text field the datetimepicker appears and has the Z timezone selected (+00:00 on 1.0-stable). An example of this is the Due field on /admin/ticket/milestones (left image). Should the user's timezone be selected by default? Additionally, perhaps the current time should be selected since the current date is selected.

The text fields that display a default value, such as Released on /admin/ticket/versions, display a default value with the user's timezone (right image).

[Jun Omae]

Replying to Ryan J Ollos:

Another potential issue, which is also seen on 1.0-stable - when clicking on an empty text field the datetimepicker appears and has the Z timezone selected (+00:00 on 1.0-stable). An example of this is the Due field on /admin/ticket/milestones (left image). Should the user's timezone be selected by default?

Right. I created #12225.

Additionally, perhaps the current time should be selected since the current date is selected.

I think no need to select current time. User can use Now button to set current time. Mostly, exact time is used. E.g. 9:30, 12:00. If current time is selected, we would have to use time sliders every time.

[Ryan J Ollos]

Replying to Jun Omae:

Replying to Ryan J Ollos:

Another potential issue, which is also seen on 1.0-stable - when clicking on an empty text field the datetimepicker appears and has the Z timezone selected (+00:00 on 1.0-stable).

Do you have an opinion in whether Z or +00:00 should be displayed in the timezone selection list? Using Z seems confusing to me, but maybe that's convention?

I think no need to select current time. User can use Now button to set current time. Mostly, exact time is used. E.g. 9:30, 12:00. If current time is selected, we would have to use time sliders every time.

That makes sense.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12220_tz_list. In particular, does the change in [b68cbb60/rjollos.git] make sense, or rather is the label used in some way that I do not see?

[Ryan J Ollos]

Replying to Ryan J Ollos:

In particular, does the change in [0524ce73/rjollos.git] make sense, or rather is the label used in some way that I do not see?

I re-read #11413 and did some testing. The behavior looks correct to me after [0524ce73/rjollos.git] (note the use of None rather than [] that caused the problems reported in #11413).

[Ryan J Ollos]

Committed to trunk in [14362].