Edgewall Software
Modify

Opened 5 years ago

Closed 2 months ago

Last modified 2 months ago

#12213 closed enhancement (fixed)

Show actual value of default on preferences pages

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.5.1
Component: general Version:
Severity: normal Keywords: bitesized preferences
Cc: Branch:
Release Notes:

The default value is shown on the preferences page in the label of the default selection of various Select inputs.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

The Localization preferences pages has selections for Date format and Time format (Trac 1.1.x). The default values are Default date format and Default format, respectively. We should show the actual value of the default as well. For example,

Data format: Default (ISO8601)

Time format: Default (Relative)

The same should be done for Language, Time zone and Syntax Highlighting: Style. This is already done for User Interface: Default Handler.

Attachments (1)

Screen Shot 2017-01-30 at 20.23.15.png (55.3 KB ) - added by Ryan J Ollos 4 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by Ryan J Ollos, 4 years ago

Milestone: next-major-releases1.3.1

comment:2 by Ryan J Ollos, 4 years ago

Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: newassigned

comment:3 by Christian Boos, 4 years ago

Milestone: 1.3.1next-dev-1.3.x

Moving to some later 1.3.x version.

by Ryan J Ollos, 4 years ago

comment:4 by Christian Boos, 4 years ago

I see that in rjollos.git@t12213_pref_defaults you modify the templates.

Looks good to me. but don't forget to switch to the ${...} form of variable expansion when merging on trunk!

(… as I plan to merge the Jinja2 branch today)

comment:5 by Ryan J Ollos, 4 years ago

Yeah, those changes need a bit more work, I was just stashing them away. I'll rebase on your Jinja2 work before continuing. Thanks.

comment:6 by Jun Omae, 3 years ago

Milestone: next-dev-1.3.xnext-stable-1.2.x

comment:7 by Ryan J Ollos, 12 months ago

Owner: Ryan J Ollos removed
Status: assignednew

comment:8 by Ryan J Ollos, 12 months ago

Milestone: next-stable-1.2.xnext-major-releases

comment:9 by Ryan J Ollos, 2 months ago

Milestone: next-major-releases1.5.1
Owner: set to Ryan J Ollos
Status: newassigned

comment:10 by Ryan J Ollos, 2 months ago

Description: modified (diff)

comment:11 by Ryan J Ollos, 2 months ago

Proposed changes [acf9b352d/rjollos.git].

In prefs_pygments.html I tried:

var stylesheet = idx > 0 ? text : text.split(':')[1].trim();  // Strip off "Default: "

It seems like it would be fine, but I'm concerned it wouldn't work if the Default: %(default)s string wasn't translated with the :. So instead default_style is passed as script data.

comment:12 by Ryan J Ollos, 2 months ago

Resolution: fixed
Status: assignedclosed

Committed to trunk in r17363.

comment:13 by Ryan J Ollos, 2 months ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.