#12213 closed enhancement (fixed)
Show actual value of default on preferences pages
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.5.1 |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | bitesized preferences |
| Cc: | Branch: | ||
| Release Notes: |
The default value is shown on the preferences page in the label of the default selection of various Select inputs. |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
The Localization preferences pages has selections for Date format and Time format (Trac 1.1.x). The default values are Default date format and Default format, respectively. We should show the actual value of the default as well. For example,
Data format: Default (ISO8601)
Time format: Default (Relative)
The same should be done for Language, Time zone and Syntax Highlighting: Style. This is already done for User Interface: Default Handler.
Attachments (1)
Change History (14)
comment:1 by , 8 years ago
| Milestone: | next-major-releases → 1.3.1 |
|---|
comment:2 by , 8 years ago
| Owner: | set to |
|---|---|
| Release Notes: | modified (diff) |
| Status: | new → assigned |
comment:3 by , 8 years ago
| Milestone: | 1.3.1 → next-dev-1.3.x |
|---|
by , 8 years ago
| Attachment: | Screen Shot 2017-01-30 at 20.23.15.png added |
|---|
comment:4 by , 8 years ago
I see that in rjollos.git@t12213_pref_defaults you modify the templates.
Looks good to me. but don't forget to switch to the ${...} form of variable expansion when merging on trunk!
(… as I plan to merge the Jinja2 branch today)
comment:5 by , 8 years ago
Yeah, those changes need a bit more work, I was just stashing them away. I'll rebase on your Jinja2 work before continuing. Thanks.
comment:7 by , 5 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:8 by , 5 years ago
| Milestone: | next-stable-1.2.x → next-major-releases |
|---|
comment:9 by , 5 years ago
| Milestone: | next-major-releases → 1.5.1 |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
comment:10 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:11 by , 5 years ago
Proposed changes [acf9b352d/rjollos.git].
In prefs_pygments.html I tried:
var stylesheet = idx > 0 ? text : text.split(':')[1].trim(); // Strip off "Default: "
It seems like it would be fine, but I'm concerned it wouldn't work if the Default: %(default)s string wasn't translated with the :. So instead default_style is passed as script data.
comment:12 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed to trunk in r17363.
comment:13 by , 5 years ago
| Release Notes: | modified (diff) |
|---|
Moving to some later 1.3.x version.