Opened 10 years ago
Closed 10 years ago
#12209 closed defect (fixed)
Cannot save notify_subscription in PostgreSQL
| Reported by: | Owned by: | Jun Omae | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2 |
| Component: | notification | Version: | 1.1.6 |
| Severity: | major | Keywords: | postgresql |
| Cc: | Branch: | ||
| Release Notes: |
Fix not working notification preference panel with PostgreSQL. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
When trying to save subscriptions in notification preference panel I am getting an error:
Trac detected an internal error:
ProgrammingError: operator does not exist: integer = boolean
LINE 2: ... WHERE sid='framay' AND authenticated=true
^
HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.
trac.log shows the full SQL:
2015-09-21 15:16:45,165 Trac[build\bdist.win32\egg\trac\db\util] DEBUG: SQL: SELECT id, distribu
tor, class FROM notify_subscription
WHERE sid=%s AND authenticated=%s
2015-09-21 15:16:45,165 Trac[build\bdist.win32\egg\trac\db\util] DEBUG: args: (u'framay', True)
I am using PostgreSQL, where the column authenticated is of type integer, thus above SQL is not correct, also the insert statement later in the method Subscription.replace_all.
Attachments (1)
Change History (7)
comment:1 by , 10 years ago
| Milestone: | → 1.2 |
|---|
comment:2 by , 10 years ago
| Keywords: | postgresql added; postgres removed |
|---|
comment:3 by , 10 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:4 by , 10 years ago
| Owner: | changed from to |
|---|
We should add unit tests for Subscription class…. I'll try to fix it.
comment:5 by , 10 years ago
| Release Notes: | modified (diff) |
|---|
Proposed changes in log:jomae.git@t12209.
by , 9 years ago
| Attachment: | ticket-14571.patch added |
|---|
FWIW this bug still exists in Trac 1.1.6 (I realize a 1.1.x release simply hasn't been made since this fix was merged). So if anyone is running Trac 1.1.6 and runs into this, I am attaching a patch for this that applies cleanly to Trac 1.1.6.
Confirmed.